Problem/Motivation

In #2708411-36: [PP-1] editor.module's editor_file_reference filter not tracking file usage correctly for translations, Entity API's confusing handling of revisions & translations was criticized. @Gábor Hojtsy provided a good explanation in #2708411-40: [PP-1] editor.module's editor_file_reference filter not tracking file usage correctly for translations. And @dawehner then suggested to document this more clearly.

Proposed resolution

Add such documentation.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#8 2892377-8.patch1.29 KBWim Leers
#8 interdiff.txt1.1 KBWim Leers
#6 2892377-6.patch1.3 KBWim Leers
#6 interdiff.txt1.46 KBWim Leers
#2 2892377-2.patch1.25 KBWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers created an issue. See original summary.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Active » Needs review
FileSize
2892377-2.patch1.25 KB

Please credit Gábor Hojtsy!

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

vijaycs85’s picture

vijaycs85
Location London, UK
CreditAttribution: vijaycs85 as a volunteer and at TATA Consultancy Services, Solathat for Pfizer, Inc. commented
Status: Needs review » Reviewed & tested by the community

Wow, it is plain and simple. I think we should get this in. Could be improved, if don't like spreadsheet :)

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Reviewed & tested by the community » Needs work

Reviewing my own text :)

  1. +++ b/core/lib/Drupal/Core/Entity/entity.api.php
@@ -113,6 +113,17 @@
+ * of an entity. If you use the UI and have revisions enabled, then a new

    Let's say "built-in UI" or "core UI" then? Other UIs could provide different experiences. 

  2. +++ b/core/lib/Drupal/Core/Entity/entity.api.php
@@ -113,6 +113,17 @@
+ * other languages in that revision). If you don't use revisions or you use the
+ * API, then you can change multiple translations within one revision.

    "If you don't use revisions" alongside "within one revision" sounds odd in official docs :) We should probably differentiate between "revisions" in the sense of configured on the entity and as in the API always dealing with it.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs work » Needs review
FileSize
interdiff.txt1.46 KB
2892377-6.patch1.3 KB

Hah!

  1. Done.
  2. Tried to improve this.
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Needs review » Needs work 
+++ b/core/lib/Drupal/Core/Entity/entity.api.php
@@ -117,12 +117,12 @@
+ * the entity is being modified via the API, then you multiple translations can

you multiple translations (left a "you" there)

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs work » Needs review
FileSize
interdiff.txt1.1 KB
2892377-8.patch1.29 KB

😳

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Dazzle commented
Status: Needs review » Reviewed & tested by the community

Both #5 and #7 are resolved, all new text looks good.

  • Gábor Hojtsy committed a58ee8d on 8.5.x 
    Issue #2892377 by Wim Leers, Gábor Hojtsy: Document relationship of...

  • Gábor Hojtsy committed eaa297c on 8.4.x 
    Issue #2892377 by Wim Leers, Gábor Hojtsy: Document relationship of...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach for Acquia commented

The documentation added here is beeing extended in #2929496: Add dedicated interfaces to group methods dealing with revision translation and clean up the related documentation.