Hi there!

I retweet interesting looking modules that pop up via the @drupal8modules account. It tweeted about a release of your module and Bojan from @CommercGuys replied suggesting that this approach is not the best strategy:

Bojan Živanović‏
@bojan_zivanovic
Replying to @drupal8modules @stevepurkiss
Please don't hack Address. You can always attach a regular phone field to the parent entity (Profile, User, etc).

https://twitter.com/bojan_zivanovic/status/881832634367737856

Now I don't know the background or situation, it's often not easy to know the best strategy and previously the project application process would have picked something like this up but that led to people waiting for years for projects to be approved, so instead we now need to help each other by pointing things like this out when we see it and find out if there are genuine good reasons for this approach to have been taken.

I suggested to Bojan that he post an issue here but realise he's a busy man so thought I might as well strike whilst the iron's hot and post, I hope it is of help in some way.

Comments

Anonymous’s picture

Anonymous (not verified) commented

stevepurkiss created an issue.

dishabhadra’s picture

dishabhadra commented

Hello,

Thank you for providing the suggestion.

This module is extending the Address module. Created the new field type.

Use case: We can add the phone field but this field will not provide validation based on Address. We need a phone number that must be validated based on Address selected i.e based on Country code.

May be a better solution will be the Address module itself to provide the phone number field.