Remove @codingStandardsIgnoreFile from file and ignore those in phpcs.xml.dist

So the proxy classes and database dump files are auto-generated by \Drupal\Core\Command\GenerateProxyClassCommand and \Drupal\Core\Command\DbDumpCommand, respectively. So we need to remove that line from the templates in those files. And ideally re-run them (at least on a couple files) to validate that the output still matches.

Oops, I am a total dummy. Sorry about that!

1. +++ b/core/phpcs.xml.dist
   @@ -8,7 +8,19 @@
   +  <exclude-pattern>./core/modules/*/tests/fixtures/*</exclude-pattern>
   

   I'm not sure about this; it's really broad. There are a lot more fixtures than the ones ignored:

   [ibnsina:drupal | Sun 14:18:18] $ ls -lR `find ./core -name "fixtures"` | grep "^-" | wc -l
        111

   Also, most of those 111 files are not intentionally empty or violating coding standards (which is what the header comment says).

2. +++ b/core/phpcs.xml.dist
   @@ -8,7 +8,19 @@
   +  <exclude-pattern>./core/lib/Drupal/Core/DependencyInjection/ContainerBuilder.php</exclude-pattern>
   +  <exclude-pattern>./core/lib/Drupal/Core/DependencyInjection/YamlFileLoader.php</exclude-pattern>
   +  <exclude-pattern>./core/tests/Drupal/Tests/Component/EventDispatcher/ContainerAwareEventDispatcherTest.php</exclude-pattern>
   

   Hm, can we confirm with references that these should be considered "third-party code"? A blame/reference of the issue that added the the ignore would be nice to confirm this.

3. +++ b/core/phpcs.xml.dist
   @@ -8,7 +8,19 @@
   +  <!--Exclude auto generated proxy classes. -->
   

   Nit: auto-generated.

   Also, it looks like this is missing an initial space. I introduced that problem in the other patch I think. The comment on the first section has neither an initial nor trailing space; the later ones have both initial and trailing spaces. AFAIK initial and trailing spaces are the correct standard.

4. +++ b/core/phpcs.xml.dist
   @@ -8,7 +8,19 @@
   +  <exclude-pattern>./core/lib/Drupal/Core/ProxyClass/*</exclude-pattern>
   +  <exclude-pattern>./core/modules/*/src/ProxyClass/*</exclude-pattern>
   

   I wasn't sure about this, but I did confirm that the namespace for the proxy class is enforced:

         $proxy_filename = $namespace_root . '/ProxyClass/' . str_replace('\\', '/', $rest_fqcn) . '.php';
         $proxy_class_name = $root_namespace . '\\ProxyClass\\' . $rest_fqcn;
   
   

   I wonder if we could use something narrower than *? OTOH it's not that likely that we're going to add other things with this namespace pattern if they aren't the generated classes.

Another thing to note is that a trailing asterisk doesn't seem to be necessary to recursively match all the files within a directory (see the diff rule and others). So we could probably be consistent about that too.

For #2, I noticed this as well when looking into the other issue. Yet another issue probably? And 8.4.x-only for that issue since (unfortunately) file removals can be disruptive when backported.

If we tighten the rules up on this one, I think we can probably consider it for backport since then it would just be implementing the same coding standards coverage and avoiding branch divergence.

Thanks!

Updated the comment. The fixtures file shouldn't be included imo.

The thing is it's not just one or a handful of files. There are over 100 test fixtures, 57 of which are PHP files, and clearly the majority already comply with our coding standards. I don't think we should disregard coding standards on arbitrary PHP test fixtures.

Ideally this patch would mostly replace the current ignore comments so that the same files are ignored, rather than significantly broadening the scope of what's ignored.

Thanks for the issue links in #12.2. It doesn't look like any of those issues added the comments to ignore the files though? Edit: What I'm trying to get at is the reasoning behind the decision to ignore them in each case, which presumably is discussed in the issues where we started ignoring them.

Closing as a duplicate of #3207968: Replace @codingStandards comments with phpcs: comments.