Replace @codingStandards comments with phpcs: comments

Didn't spot these initially either; while we are here I guess we should change them too for consistency.

These need to become phpcs:ignore, phpcs:disable or phpcs:enable as appropriate.

core/modules/block/src/Plugin/migrate/process/BlockVisibility.php
58:  // @codingStandardsIgnoreLine

core/modules/migrate/src/Plugin/migrate/process/MigrationLookup.php
148:  // @codingStandardsIgnoreLine

core/modules/migrate/src/Plugin/migrate/process/MenuLinkParent.php
107:  // @codingStandardsIgnoreLine

core/tests/Drupal/KernelTests/Core/Theme/TwigMarkupInterfaceTest.php
48:      // @codingStandardsIgnoreStart
52:      // @codingStandardsIgnoreEnd

core/tests/Drupal/Tests/ComposerIntegrationTest.php
208:  // @codingStandardsIgnoreStart
252:  // @codingStandardsIgnoreEnd

core/lib/Drupal/Core/TypedData/Validation/ExecutionContextFactory.php
14: * @codingStandardsIgnoreStart

core/lib/Drupal/Core/TypedData/Validation/ConstraintViolationBuilder.php
17: * @codingStandardsIgnoreStart

core/modules/jsonapi/tests/src/Functional/MediaTest.php
345:  // @codingStandardsIgnoreStart
354:  // @codingStandardsIgnoreEnd

Comments below might be a bit of scope creep but I think better to fix them here than open lots of new issues for these tiny little changes.

1. +++ b/core/lib/Drupal/Core/TypedData/Validation/ExecutionContextFactory.php
   @@ -33,8 +31,10 @@ class ExecutionContextFactory implements ExecutionContextFactoryInterface {
   +  // phpcs:disable
      public function __construct(TranslatorInterface $translator, $translationDomain = null)
      {
   +  // phpcs:enable
   

   I think we should just fix the coding standards issues on these lines.

2. +++ b/core/lib/Drupal/Core/TypedData/Validation/ExecutionContextFactory.php
   @@ -43,6 +43,7 @@ public function __construct(TranslatorInterface $translator, $translationDomain
      public function createContext(ValidatorInterface $validator, $root)
   +  // phpcs:ignore
      {
   

   And here.

3. +++ b/core/modules/block/src/Plugin/migrate/process/BlockVisibility.php
   @@ -55,7 +55,7 @@ class BlockVisibility extends ProcessPluginBase implements ContainerFactoryPlugi
   -  // @codingStandardsIgnoreLine
   +  // phpcs:ignore
      public function __construct(array $configuration, $plugin_id, $plugin_definition, ModuleHandlerInterface $module_handler, MigrateLookupInterface $migrate_lookup) {
   

   What issue are we ignoring here?

4. +++ b/core/modules/jsonapi/tests/src/Functional/MediaTest.php
   @@ -342,7 +342,7 @@ protected function getExpectedUnauthorizedAccessCacheability() {
   -  // @codingStandardsIgnoreStart
   +  // phpcs:disable
   
   @@ -351,7 +351,7 @@ public function testPostIndividual() {
   -  // @codingStandardsIgnoreEnd
   +  // phpcs:enable
   

   I think this can just be removed?

5. +++ b/core/tests/Drupal/KernelTests/Core/Theme/TwigMarkupInterfaceTest.php
   @@ -45,11 +45,11 @@ public function testMarkupInterfaceEmpty($expected, $variable) {
   -      // @codingStandardsIgnoreStart
   +      // phpcs:disable
          // The first argument to \Drupal\Core\StringTranslation\TranslatableMarkup
          // is not supposed to be an empty string.
          'empty TranslatableMarkup' => ['', new TranslatableMarkup('')],
   -      // @codingStandardsIgnoreEnd
   +      // phpcs:enable
   

   Maybe we can use // phpcs:ignore Drupal.Semantics.FunctionT.EmptyString here?

Also a wider question: in phpcs.xml.dist we ignore the Diff component:

  <!-- Exclude third-party code maintained within core that does not follow our standards. -->
  <!-- @todo This rule may be removed when https://www.drupal.org/node/1848264 is resolved. -->
  <exclude-pattern>./core/lib/Drupal/Component/Diff/</exclude-pattern>

Should we do this for the Doctrine tests instead of adding a line to each file?

(we could do the same for ProxyClass implementations, but I think as those can live in any namespace and are machine-generated it is worth explicitly including the tag)

+++ b/core/lib/Drupal/Core/TypedData/Validation/ExecutionContextFactory.php
@@ -43,6 +40,7 @@ public function __construct(TranslatorInterface $translator, $translationDomain
   public function createContext(ValidatorInterface $validator, $root)
+  // phpcs:ignore
   {

This was missed from #8.2, I think we just need to move the brace to the declaration line? Otherwise this looks good to me.

I didn't find the duplicate issue earlier, oops. I think this is hopefully less controversial. My personal opinion is that we should use the config file to exclude wide groups of files (e.g. entire namespaces) but then use inline comments for individual files that have individual reasons for being ignored.

Thanks, this looks good to me now.

I also opened #3208698: Make ProxyClass implementations follow coding standards as I think the best fix overall would be to make the ProxyClass implementations actually follow the standards, this should be possible with a little more effort in the generator code.

Great work, I agree with all the additions in #24 so back to RTBC.

Random fail in EntityReferenceWidgetTest.