I just installed 8.4.x from scratch and the toolbar menus are always expanded and I cannot collapse them:

CommentFileSizeAuthor
#4 Before Mobile.jpeg266.28 KBkrina.addweb
#4 After Mobile.jpeg244.05 KBkrina.addweb
#4 Before patch.png18.76 KBkrina.addweb
#4 After Patch.png17.08 KBkrina.addweb
#2 toolbar_menus_always-2891236-2.patch988 bytesdroplet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

plach created an issue. See original summary.

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Active » Needs review
FileSize
toolbar_menus_always-2891236-2.patch988 bytes

I removed the class from #2542050: Toolbar implementation creates super annoying re-rendering. accidentally. I didn't realise this is vertical

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach as a volunteer commented

This fixed the issue for me, leaving actual RTBC to people more familiar with the Toolbar code.

krina.addweb’s picture

krina.addweb CreditAttribution: krina.addweb at AddWeb Solution Pvt. Ltd. commented
Status: Needs review » Reviewed & tested by the community
FileSize
After Patch.png17.08 KB
Before patch.png18.76 KB
After Mobile.jpeg244.05 KB
Before Mobile.jpeg266.28 KB

@droplet, Thanks for the correction, it works well for me as I checked your patch with responsive using simplytest.me. PFA as results.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Title: Toolbar menus always expanded » Regression in #2542050: Toolbar menus always expanded
Issue tags: +CSS
Related issues: +#2542050: Toolbar implementation creates super annoying re-rendering.
droplet’s picture

droplet CreditAttribution: droplet commented
Related issues: +#2891307: Clean up the incorrect expanded/collapsed HTML class in Toolbar

The CSS in Toolbar is very awful.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Druid commented
Status: Reviewed & tested by the community » Fixed

Committed b5a3346 and pushed to 8.4.x. Thanks!

  • lauriii committed b5a3346 on 8.4.x 
    Issue #2891236 by droplet, krina.addweb: Regression in #2542050: Toolbar...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.