For WCAG2.0 it is desirable to be able to add the lang attribute to content as an editor. The language-plugin provides this functionality. (http://sdk.ckeditor.com/samples/language.html). Let's enable it in the default toolbar.

CommentFileSizeAuthor
#6 add_language_plugin-2891109-6.patch2.76 KBjoshahubbers
#2 add_language_plugin-2891109-2.patch2.79 KBjoshahubbers

Comments

JoshaHubbers created an issue. See original summary.

joshahubbers’s picture

joshahubbers commented
StatusFileSize
new add_language_plugin-2891109-2.patch2.79 KB

- Adds Language button to Advanced profile
- Adds config.language_list default languages to Advanced profile
- Adds dir and lang attribute to span in text format filtered html

joshahubbers’s picture

joshahubbers commented
Assigned: joshahubbers » Unassigned
Status: Active » Needs review
joshahubbers’s picture

joshahubbers commented

I think we should override config.language_list somewhere outside the feature, so it can be adapted per site without changing the DVG-profile.

paulvandenburg’s picture

paulvandenburg commented

Code looks good, functionally works.

However I've some questions regarding the intended functioning.
What languages should be available by default?
When we have languages with RTL layout (like arabic currently) what to do with that layout?

We can enable the CKEditor setting 'Load ckeditor.config.js from the theme path' to set the language list outside the dvg feature. Though that requires the active theme to be updated with the config settings currently used for that site.

joshahubbers’s picture

joshahubbers commented
StatusFileSize
new add_language_plugin-2891109-6.patch2.76 KB

Removed Turkish and Arabic. Propose to implement this, and evaluate if other language set is needed based on usage.

paulvandenburg’s picture

paulvandenburg commented
Status: Needs review » Reviewed & tested by the community

Looks good.

  • askibinski committed bccf2f0 on 7.x-1.x 
    Issue #2891109 by JoshaHubbers: Add language plugin to CKeditor

askibinski credited askibinski.

askibinski’s picture

askibinski commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.