The bootstrap theme rewrites all input[submit] into button[submit], but the new js functionality to disable actions in the case of unselected items is specifically targeting "input" elements. Should we add button[type="submit"] to the selectors for vbo.toggleButtonsState as well?

CommentFileSizeAuthor
#3 views_bulk_operations-bootstrap_compatibility-2890878-3-D7.patch711 bytesmatthensley

Comments

matthensley created an issue. See original summary.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Version: 7.x-3.4 » 7.x-3.x-dev
Category: Bug report » Feature request

yes actually, I'm all for making it work with buttons too. Please feel free to put up a patch that will make both work.

matthensley’s picture

matthensley commented
StatusFileSize
new views_bulk_operations-bootstrap_compatibility-2890878-3-D7.patch711 bytes

Cool! I've got a patch ready here. It's my first one, so let me know if something should be different about it. I took off looking for any particular selector and now it's just looking for anything of [type=input] within the given parameters. Let me know if you'd like any revisions!

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review

Changing the status so that others can review, but I think this looks perfect. Is there any other elements that would take that attribute that may collide, don't think so but want to ask the question?

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

I've committed it, not many review takers in this queue;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.