Exposed Date Filter - PHP 7 Error

I'm not sure if this is the best approach.

AFAIK you would only get this if $return wasn't an array, and it looks like the only way for that to happen is from the $return = $input; line. I'm guessing at some point $input is an empty string, rather than an array, before the first date is selected.

Untested, but perhaps it might be better to do something like:

-  if ($input !== FALSE) {
+  if ($input !== FALSE && is_array($input)) {
     $return = $input;
     $date = date_select_input_date($element, $input);
   }

I have tested this patch and it solves that problem for me just perfectly.

Hello,

I cannot reproduce this bug. I tested with 7.0.10 and the version 7.x-2.10, and I created the same kind of views described in the issue and I never got the error message.

Did I miss something?

Nevertheless, I noticed errors when I tested the views with the preview at the bottom of the "Views" definition interface but the messages are different.
In this case, the preview AJAX call returned an 500 HTTP error with a warning and a error message when I selected a month and year and used a table column filter.

Warning: Illegal string offset 'month' in drupal_array_set_nested_value() (line 6779 of /Applications/MAMP/htdocs/drupal/includes/common.inc).
Error: Cannot create references to/from string offsets nor overloaded objects in drupal_array_set_nested_value() (line 6779 of /Applications/MAMP/htdocs/drupal/includes/common.inc).

I also saw that in this case, the callback received a date value under the string format instead of the array format; e.g.: 2017-03. Should we not try to parse this value?

@jyraya, if I remember correctly, these errors only occur on PHP 7.1 and higher.

Thanks for the information, @bramvandenbulcke.

Maybe I'm confused with the other issue: https://www.drupal.org/project/date/issues/2843367.

I know I can't go higher than the latest PHP 7.0 version because of that issue on a project of mine.

Ok.

In the meantime, I tested the #4 patch in PHP 5.6, 7.0 and 7.1. It works in the 3 cases; no regression.

Seems like even with the #4 patch there is still an issue with PHP 7.1:

As the original post states:

• Exposed Date Filter for Month/Year
• Table format
• Clickable / Sortable Table Columns

Do not apply any filters. If you sort by any field: Cannot create references to/from string offsets in drupal_array_set_nested_value()

If you first apply a filter, then sort: No issues.

Looking closer at the URL.
Sorting without filtering first looks like this:field_date_value[value]
If you filter first (and it works): field_date_value[value][month]=2&field_date_value[value][year]=2017

Does not seem to be an issue with PHP 7.0. but only 7.1

A bit more research. Might be related to this issue: https://www.drupal.org/project/drupal/issues/2313517

The latest patch above should be committed as-is and a release published in a new release of the date module version 2.11.
However for php 7.1 , open a new issue and add a link reference here.

@josepholstad Alright. Will do. https://www.drupal.org/project/date/issues/2961859

The patch in #4 does not resolve all the issues in play here. Strictly speaking, it resolves things where the end user is playing nice, but not when the end user plays with the URL's query string.

I am running on PHP 7.1, and I have a view with an exposed date filter which is filtering on year component only. Let's call the underlying field field_released_date. As expected, when someone alters the exposed filter value, it sends this query string:

example.com/myview?field_released_date_value[value][year]=2018

But if someone manually changes the URL to this:

example.com/myview?field_released_date_value[value]=2018

I get the same warning + fatal error reported in #6.

for php 7.1 , please see related issue
#2961859: PHP 7.1 Exposed Date Field Issue WSOD Fatal Error: Cannot create references to/from string offsets

lets get 7.0 working first, meanwhile work on 7.1 can continue in #2961859: PHP 7.1 Exposed Date Field Issue WSOD Fatal Error: Cannot create references to/from string offsets

This is an excellent fix, thank you. We'll add it to the next release.

Committed! Thank you all for your help.

When a column in a table is selected for sorting from a view the system responds with
Warning: Illegal string offset 'month' in date_select_element_value_callback() (line 467 of /home/www/html//sites/all/modules/date/date_api/date_api_elements.inc).
Warning: Cannot assign an empty string to a string offset in date_select_element_value_callback() (line 467 of /home/www/html//sites/all/modules/date/date_api/date_api_elements.inc).
Warning: Illegal string offset 'day' in date_select_element_value_callback() (line 467 of /home/www/html//sites/all/modules/date/date_api/date_api_elements.inc).
Warning: Cannot assign an empty string to a string offset in date_select_element_value_callback() (line 467 of /home/www/html//sites/all/modules/date/date_api/date_api_elements.inc).
Warning: Illegal string offset 'year' in date_select_element_value_callback() (line 467 of /home/www/html//sites/all/modules/date/date_api/date_api_elements.inc).
Warning: Cannot assign an empty string to a string offset in date_select_element_value_callback() (line 467 of /home/www/html//sites/all/modules/date/date_api/date_api_elements.inc).
Warning: Illegal string offset 'month' in drupal_array_set_nested_value() (line 6794 of /home/www/html/atn/includes/common.inc).
Error: Cannot create references to/from string offsets in drupal_array_set_nested_value() (line 6794 of /home/www/html/atn/includes/common.inc).

I can get the date_api_elements.inc warnings to be removed applying ladybug_3777's patches #2 & #4, but it still shows

Warning: Illegal string offset 'month' in drupal_array_set_nested_value() (line 6779 of /Applications/MAMP/htdocs/drupal/includes/common.inc).
Error: Cannot create references to/from string offsets nor overloaded objects in drupal_array_set_nested_value() (line 6779 of /Applications/MAMP/htdocs/drupal/includes/common.inc).

@stevecory: This issue was fixed a while ago, it sounds like you need to test the current dev snapshot and if the problem still exists look for another issue or create a new one.