Fix PHP 7 tests [#2889636]

Comment	File	Size	Author
#7	date-2889636-7.patch	4.08 KB	MustangGB
#7	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 45 pass PHP 7 & MySQL 5.5, D7 45 pass
#6	date-2889636-6.patch	1002 bytes	MustangGB
#6	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 45 pass PHP 7 & MySQL 5.5, D7 35 pass, 13 fail PHP 7.1 & MySQL 5.5, D7 35 pass, 15 fail
#5	date-2889636-5.patch	1.65 KB	MustangGB
#5	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 45 pass PHP 7 & MySQL 5.5, D7 35 pass, 13 fail PHP 7.1 & MySQL 5.5, D7 35 pass, 13 fail
#3	date-2889636-3.patch	2.5 KB	MustangGB
#3	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 35 pass, 13 fail PHP 5.4 & MySQL 5.5, D7 35 pass, 13 fail PHP 5.5 & MySQL 5.5, D7 35 pass, 13 fail PHP 5.6 & MySQL 5.5, D7 35 pass, 13 fail PHP 7 & MySQL 5.5, D7 45 pass PHP 7.1 & MySQL 5.5, D7 45 pass
#2	date-2889636-2.patch	1.82 KB	MustangGB
#2	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 35 pass, 13 fail PHP 5.4 & MySQL 5.5, D7 35 pass, 13 fail PHP 5.5 & MySQL 5.5, D7 35 pass, 13 fail PHP 5.6 & MySQL 5.5, D7 35 pass, 13 fail PHP 7 & MySQL 5.5, D7 45 pass PHP 7.1 & MySQL 5.5, D7 45 pass, 2 fail
	before.patch	255 bytes	MustangGB
	7.x-2.x: PHP 5.3 & MySQL 5.5, D7 45 pass PHP 5.4 & MySQL 5.5, D7 45 pass PHP 5.5 & MySQL 5.5, D7 45 pass PHP 5.6 & MySQL 5.5, D7 45 pass PHP 7 & MySQL 5.5, D7 35 pass, 13 fail PHP 7.1 & MySQL 5.5, D7 35 pass, 15 fail

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

26 June 2017 at 12:39

MustangGB created an issue. See original summary.

Comment #3

MustangGB CreditAttribution: MustangGB commented 26 June 2017 at 13:07

File	Size
date-2889636-3.patch	2.5 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 35 pass, 13 fail PHP 5.4 & MySQL 5.5, D7 35 pass, 13 fail PHP 5.5 & MySQL 5.5, D7 35 pass, 13 fail PHP 5.6 & MySQL 5.5, D7 35 pass, 13 fail PHP 7 & MySQL 5.5, D7 45 pass PHP 7.1 & MySQL 5.5, D7 45 pass

Looks like the testMultiUserTimezone() failures are due to 'cardinality' => 3,, this results in empty date values on the node/add page, which seems to be resolved by #2843367: String Offset errors on edit page using PHP 7.1.0.

So trying a combined patch.

Comment #4

MustangGB CreditAttribution: MustangGB commented 27 June 2017 at 10:09

Well green sheets on PHP7 is a start, at least we know where the issue lies now.

Comment #5

MustangGB CreditAttribution: MustangGB commented 27 June 2017 at 10:24

File	Size
date-2889636-5.patch	1.65 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 45 pass PHP 7 & MySQL 5.5, D7 35 pass, 13 fail PHP 7.1 & MySQL 5.5, D7 35 pass, 13 fail

Trying a different method, still combined with #2843367: String Offset errors on edit page using PHP 7.1.0.

Comment #6

MustangGB CreditAttribution: MustangGB commented 27 June 2017 at 10:27

File	Size
date-2889636-6.patch	1002 bytes
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 45 pass PHP 7 & MySQL 5.5, D7 35 pass, 13 fail PHP 7.1 & MySQL 5.5, D7 35 pass, 15 fail

And in-case that passes cleanly here is the kitty friendly version, i.e. non-combined.

Comment #7

MustangGB CreditAttribution: MustangGB commented 27 June 2017 at 11:22

File	Size
date-2889636-7.patch	4.08 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 45 pass PHP 7 & MySQL 5.5, D7 45 pass

Fingers crossed.

Comment #8

MustangGB CreditAttribution: MustangGB commented 27 June 2017 at 11:32

Title:	Fix PHP 7.0/7.1 tests	» Fix PHP 7 tests
Priority:	Normal	» Major
Status:	Active	» Needs review

Great, looking good for PHP 7.0, there should still be a handful of failures for PHP 7.1 that will be resolved by #2843367: String Offset errors on edit page using PHP 7.1.0.

Comment #9

MustangGB CreditAttribution: MustangGB commented 27 June 2017 at 11:33

4 files were hidden/shown/deleted

File	Size
date-2889636-2.patch	1.82 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 35 pass, 13 fail PHP 5.4 & MySQL 5.5, D7 35 pass, 13 fail PHP 5.5 & MySQL 5.5, D7 35 pass, 13 fail PHP 5.6 & MySQL 5.5, D7 35 pass, 13 fail PHP 7 & MySQL 5.5, D7 45 pass PHP 7.1 & MySQL 5.5, D7 45 pass, 2 fail
date-2889636-3.patch	2.5 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 35 pass, 13 fail PHP 5.4 & MySQL 5.5, D7 35 pass, 13 fail PHP 5.5 & MySQL 5.5, D7 35 pass, 13 fail PHP 5.6 & MySQL 5.5, D7 35 pass, 13 fail PHP 7 & MySQL 5.5, D7 45 pass PHP 7.1 & MySQL 5.5, D7 45 pass
date-2889636-5.patch	1.65 KB
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 45 pass PHP 7 & MySQL 5.5, D7 35 pass, 13 fail PHP 7.1 & MySQL 5.5, D7 35 pass, 13 fail
date-2889636-6.patch	1002 bytes
7.x-2.x: PHP 5.3 & MySQL 5.5, D7 45 pass PHP 7 & MySQL 5.5, D7 35 pass, 13 fail PHP 7.1 & MySQL 5.5, D7 35 pass, 15 fail

Comment #10

Stevel CreditAttribution: Stevel commented 28 June 2017 at 12:38

Status:

Needs review

» Reviewed & tested by the community

Looks good, this solves the test errors in local testing as well.

Comment #11

ikeigenwijs CreditAttribution: ikeigenwijs commented 29 August 2017 at 12:06

Looks good, would be nice to get this committed to dev

Comment #12

ikeigenwijs CreditAttribution: ikeigenwijs commented 29 August 2017 at 12:08

Parent issue:

» #2867810: Plan for Date 7.x-2.11 release

Comment #13

16 January 2018 at 18:58

DamienMcKenna committed b657451 on 7.x-2.x authored by MustangGB

Issue #2889636 by MustangGB, ikeigenwijs, Stevel: Fix PHP 7 tests.

Comment #14

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 16 January 2018 at 18:58

Status:

Reviewed & tested by the community

» Fixed

Committed. Thanks!

Comment #15

30 January 2018 at 18:59

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Fix PHP 7 tests

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Comment #14

Comment #15

Parent issue

Referenced by

Thank you to these Drupal contributors

News items

Our community

Documentation

Drupal code base

Governance of community