CommentFileSizeAuthor
#7 date-2889636-7.patch4.08 KBmustanggb
#6 date-2889636-6.patch1002 bytesmustanggb
#5 date-2889636-5.patch1.65 KBmustanggb
#3 date-2889636-3.patch2.5 KBmustanggb
#2 date-2889636-2.patch1.82 KBmustanggb
before.patch255 bytesmustanggb

Comments

MustangGB created an issue. See original summary.

mustanggb’s picture

mustanggb commented
StatusFileSize
new date-2889636-2.patch1.82 KB

Lets see what breaks.

mustanggb’s picture

mustanggb commented
StatusFileSize
new date-2889636-3.patch2.5 KB

Looks like the testMultiUserTimezone() failures are due to 'cardinality' => 3,, this results in empty date values on the node/add page, which seems to be resolved by #2843367: String Offset errors on edit page using PHP 7.1.0.

So trying a combined patch.

mustanggb’s picture

mustanggb commented

Well green sheets on PHP7 is a start, at least we know where the issue lies now.

mustanggb’s picture

mustanggb commented
StatusFileSize
new date-2889636-5.patch1.65 KB

Trying a different method, still combined with #2843367: String Offset errors on edit page using PHP 7.1.0.

mustanggb’s picture

mustanggb commented
StatusFileSize
new date-2889636-6.patch1002 bytes

And in-case that passes cleanly here is the kitty friendly version, i.e. non-combined.

mustanggb’s picture

mustanggb commented
StatusFileSize
new date-2889636-7.patch4.08 KB

Fingers crossed.

mustanggb’s picture

mustanggb commented
Title: Fix PHP 7.0/7.1 tests » Fix PHP 7 tests
Priority: Normal » Major
Status: Active » Needs review

Great, looking good for PHP 7.0, there should still be a handful of failures for PHP 7.1 that will be resolved by #2843367: String Offset errors on edit page using PHP 7.1.0.

mustanggb’s picture

mustanggb commented
Stevel’s picture

Stevel commented
Status: Needs review » Reviewed & tested by the community

Looks good, this solves the test errors in local testing as well.

ikeigenwijs’s picture

ikeigenwijs commented

Looks good, would be nice to get this committed to dev

ikeigenwijs’s picture

ikeigenwijs commented
Parent issue: » #2867810: Plan for Date 7.x-2.11 release

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.