Hi,
This module works perfectly but it is limited to native Drupal styles.
I use manualcrop on my website in order to choose the part of the image to keep, but when the image is an animated gif, this module is not applied. I've done a patch to add support for the manualcrop styles. If manualcrop is not installed, it should not affect anything.
Thank you for reading this.
Comments
Comment #2
phjouComment #3
phjouComment #4
jmsv23 commentedComment #5
denes.szabo commentedHi Guys!
As I see, with this alterable style associations, this issue is solved (https://www.drupal.org/node/2888730)
Maybe we need to add a small module to build manualcrop - animgif "bridge"… Or whatever module (e.g focal_point) - animgif support bridge.
I need more info for the best practices and ideas there.
Comment #6
phjouHi,
Sorry for the delay. I agree with you Denes, it's better to do a small submodule to support manualcrop. I did a new patch in order to do that and use the drupal_alter from #2888730
I think that it's a good idea to embed a small module like this because developers don't want to do themselves the drupal_alter in each project that use animgif_support + manualcrop.
I hope it's ok for you.
Comment #7
phjouComment #8
phjouI haven't seen the focal point issue, I've read too fast ^^
I don't know if it's a better idea to do one submodule by support feature (one for manualcrop, one for focal point). On one hand with this method, we can add more code than just the associations if it's needed in the future, and the code is well separated.
On the other hand, if we do only one module we save one or more module activations.
I'm maybe more a fan of the first method, but both seem ok for me.