Hi,

This module works perfectly but it is limited to native Drupal styles.
I use manualcrop on my website in order to choose the part of the image to keep, but when the image is an animated gif, this module is not applied. I've done a patch to add support for the manualcrop styles. If manualcrop is not installed, it should not affect anything.

Thank you for reading this.

CommentFileSizeAuthor
#6 animgif_support-support_for_manualcrop_styles-2888724-6.patch2.07 KBphjou
#4 animgif_support-support_for_manualcrop_styles-2888724-3.patch1.81 KBjmsv23
#2 animgif_support-support_for_manualcrop_styles-2888724-2.patch1.09 KBphjou

Comments

phjou created an issue. See original summary.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
StatusFileSize
new animgif_support-support_for_manualcrop_styles-2888724-2.patch1.09 KB
phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
Status: Active » Needs review
jmsv23’s picture

jmsv23 commented
StatusFileSize
new animgif_support-support_for_manualcrop_styles-2888724-3.patch1.81 KB
denes.szabo’s picture

denes.szabo commented
Assigned: Unassigned » denes.szabo
Status: Needs review » Postponed (maintainer needs more info)

Hi Guys!

As I see, with this alterable style associations, this issue is solved (https://www.drupal.org/node/2888730)

Maybe we need to add a small module to build manualcrop - animgif "bridge"… Or whatever module (e.g focal_point) - animgif support bridge.

I need more info for the best practices and ideas there.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
StatusFileSize
new animgif_support-support_for_manualcrop_styles-2888724-6.patch2.07 KB

Hi,

Sorry for the delay. I agree with you Denes, it's better to do a small submodule to support manualcrop. I did a new patch in order to do that and use the drupal_alter from #2888730

I think that it's a good idea to embed a small module like this because developers don't want to do themselves the drupal_alter in each project that use animgif_support + manualcrop.

I hope it's ok for you.

phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented
Status: Postponed (maintainer needs more info) » Needs review
phjou’s picture

phjou
he/him
Location Vancouver 🇨🇦 🇪🇺
commented

I haven't seen the focal point issue, I've read too fast ^^

I don't know if it's a better idea to do one submodule by support feature (one for manualcrop, one for focal point). On one hand with this method, we can add more code than just the associations if it's needed in the future, and the code is well separated.

On the other hand, if we do only one module we save one or more module activations.

I'm maybe more a fan of the first method, but both seem ok for me.