Fix description for StylePluginBase::$usesRowPlugin property

Applying the patch, please review and suggest me if i have entered a wrong description. I have taken StylePluginBase class in the description.

@chi i didn't provide patch for spelling, i consider description based on StylePluginBase class. Sorry if I am wrong.

#7 +1
I have checked its usage. According to its usage and the property name, it should be "To use Row plugins"

Updated IS accordingly

Changes made according to comment #8.

Thank you.

Thanks!

Sorry but "To use Row plugins" does not sound like a proper English sentence to me. I would suggest something like "Whether or not this style uses a row plugin."

Also all other instances beside StylePluginBase should be changed to simply

/**
 * {@inheritdoc}
 */

So we don't have to duplicate the documentation.

Agree with #11. Updated the patch accordingly.

That's the direction I was talking about. Thanks @pk188! One minor problem, though, with the last patch:

+++ b/core/modules/views/src/Plugin/views/style/DefaultStyle.php
@@ -19,10 +19,12 @@
   /**
...
    * @var bool
    */

This should be removed as well (except for StylePluginBase).

My mistake.
Fixed #13.

I have applied the patch and checked it locally. It still needs to apply the {@inheritdoc} to these child classes of StylePluginBase.

- Drupal\views\Plugin\views\style\Opml
- Drupal\views\Plugin\views\style\Rss
- Drupal\views_test_data\Plugin\views\style\StyleTemplateTest
- Drupal\views_test_data\Plugin\views\style\StyleTest

back to N/W for this

Thanks @pk188, that's perfect.

I found some more plugins that need updating: Opml, Rss, StyleTemplateTest, StyleTest

I think we should update those too, then this is RTBC.

Oops, crosspost with @naveenvalecha in #15, sorry. But great that we came to the same conclusion ;-)

Fixed #15.

Thanks @pk188
Verified the latest patch on local and it addressed my concerns in #15

//Naveen

Thanks, looks good to me too, committed.

What's the status of issue. As @Gábor Hojtsy fixed and committed it, but it's status is still RTBC and no credit given to anybody.

Please don't change the status of this issue. I have pinged the @mixologic over IRC to look into that so that he would be able to reproduce the issue and fix the issue on drupal.org

The issue has already fixed and committed. So that's why failed to apply.

@Gábor Hojtsy credit is not given to anyone, there is any reason for that? Can you please tell.

I'm getting unnecessary notifications email just for the credit stuff which I really don't care. Ping Gabor over IRC regarding credit system(which I think not an issue if we'll not get the credit here)

P.S. :Unfollowing this issue as I don't feel there's anything else required to be done here.
//Naveen