Problem/Motivation

In working on #2871646: hook_entity_save support for import and delete API operations it got me thinking that it would be a nice fit to move to a model of the base module having everything necessary to programatically support the RSS and API approach, and then having super light sub-modules for views and api. This is very easy since we're now using the Serialization system, and does not depend on views for RSS approach like we did in D7. The _views sub-module would just be the filter and default view config. The api would just be a hook_entity_save, hook_entity_delete, and alter hook to insert business logic. Leaving it super easy for developers to just turn on the base module and go with their own solution if they want (eg. importing via drush, using a queue, using rules module, vbo, completely custom hook_entity_save, etc.), or turn on a default super simple and lightweight out of the box integration for either RSS or API.

Proposed resolution

Move all non-view related code from _views sub-module into the base module. Move all code from the _api module into the base module. _api module becomes use of the API approach on hook_entity_save and hook_entity_delete.

Remaining tasks

Implement

User interface changes

API settings form will live in the base module and will be available by default. Should add text to explain it's purpose better if it doesn't do that already.

API changes

None.

Data model changes

None.

Comments

m4olivei created an issue. See original summary.

m4olivei’s picture

Issue summary: View changes
m4olivei’s picture

sunset_bill’s picture

Status: Needs review » Reviewed & tested by the community

I've tried it out and things worked as expected for me.

sunset_bill’s picture

  • m4olivei committed 03cd19a on 8.x-2.x
    Issue #2888573 move common pieces of _views module into the base module.
    
  • m4olivei authored 39fcec5 on 8.x-2.x
    Issue #2888573 by m4olivei, sunset_bill: Refactor all common code into...
  • m4olivei committed da118ff on 8.x-2.x
    Issue #2888573 move _api sub module code into the base module and re-...
m4olivei’s picture

Status: Reviewed & tested by the community » Fixed

Thanks Bill. Merged.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.