Followup from the project application at #2875485: [D8] Compact date/time range formatter

To allow other modules to extend classes, it is preferable to use protected rather than private local functions. An extending class will not have access to superclass private functions.

CommentFileSizeAuthor
#2 daterange_compact-protected-functions-2887922-1.patch1003 bytesjohnpitcairn

Issue fork daterange_compact-2887922

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

John Pitcairn created an issue. See original summary.

johnpitcairn’s picture

johnpitcairn commented
Status: Active » Needs review
StatusFileSize
new daterange_compact-protected-functions-2887922-1.patch1003 bytes

And patch.

This patch changes the private functions in the DateRangeFormatListBuilder class to protected.

tim-diels made their first commit to this issue’s fork.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Version: 8.x-1.x-dev » 2.0.0

  • erik.erskine committed 36b7a749 on 2.1.x 
    Use protected not private to allow extending classes #2887922
erik.erskine’s picture

erik.erskine commented
Status: Needs review » Fixed

Fixed in 2.1.0

Thanks :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.