Problem/Motivation

On the Available Updates page (by URL: domain.tld/admin/reports/updates/update) under the Contrib section in the Core section there's a message saying: "Updates of Drupal core are not supported at this time." In my opinion this sounds misleading, because this is only about automatically performed updates, not in general. A novice admin user may misunderstands whether their core is ready to be updated or not? Of course it's ready, but only manually.

Here on localize.drupal.org you can see that this string with ID#354960 is quite old, has been used since D7.x first alpha release.

Proposed resolution

Insert the missing word "Automatic" (or any synonym) into the beginning of the string forming "Automatic updates of Drupal core are not supported at this time." This would became into a new string on l.d.o.

Remaining tasks

AFAIK this string occurs in core/modules/update/src/Form/UpdateManagerUpdate.php at line #281:
String in code

if (!empty($projects['manual'])) {
      $prefix = '<h2>' . $this->t('Manual updates required') . '</h2>';
      $prefix .= '<p>' . $this->t('Updates of Drupal core are not supported at this time.') . '</p>';
      $form['manual_updates'] = [
        '#type' => 'table',
        '#header' => $headers,
        '#rows' => $projects['manual'],
        '#prefix' => $prefix,
        '#weight' => 120,
      ];
    }

User interface changes

Only intentional UI string change.

API changes

No.

Data model changes

No.

CommentFileSizeAuthor
#4 2887114-4.patch789 bytesalauzon
update-string-in-code.png72.48 KBbaluertl

Comments

Balu Ertl created an issue. See original summary.

cilefen’s picture

Version: 8.3.3 » 8.4.x-dev
Issue tags: +Novice

Good point! We cannot change translatable strings in patch releases so this goes in 8.4.x.

alauzon’s picture

I'm working on it from DrupalCampMontréal2017 sprint.

alauzon’s picture

Status: Active » Needs review
StatusFileSize
new789 bytes

Here is a patch doing exactly that.

maxocub’s picture

Status: Needs review » Reviewed & tested by the community
naveenvalecha’s picture

Issue tags: +String change in 8.4.0

RTBC +1
This is a string change. However, we are too much far from 8.4.0 so that shouldn't should be fine.

//Naveen

  • xjm committed b3002ff on 8.3.x
    Issue #2887114 by alauzon, Balu Ertl: Misleading text on automatic/...
xjm’s picture

Status: Reviewed & tested by the community » Fixed

That improved string makes more sense to me as well. Committed and pushed to 8.4.s at DrupalCamp Montréal. Thanks @alauzon!

  • xjm committed 785966a on 8.3.x
    Revert "Issue #2887114 by alauzon, Balu Ertl: Misleading text on...

  • xjm committed 86f49c2 on 8.4.x
    Issue #2887114 by alauzon, Balu Ertl: Misleading text on automatic/...
xjm’s picture

Oops, committed it to the wrong branch by mistake. Revert and recommit is me fixing that.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.