Problem/Motivation

See #2847708-48: RPC endpoint to reset user password.

Proposed resolution

Follow the same approach as interdiff, but for ::testLogin()

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#4 refactor-2886198-4.patch8.88 KBacbramley

Comments

Wim Leers created an issue. See original summary.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Title: Refactor \UserLoginHttpTest::testLogin() to use a @dataProvider » Refactor \UserLoginHttpTest::testLogin() to use a protected method and remove the nested loops
Issue summary: View changes
acbramley’s picture

acbramley commented
Assigned: Unassigned » acbramley
Status: Postponed » Active
acbramley’s picture

acbramley commented
Assigned: acbramley » Unassigned
Status: Active » Needs review
StatusFileSize
new refactor-2886198-4.patch8.88 KB

Patch attached closely follows #2847708-48: RPC endpoint to reset user password

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community

Unless bot says otherwise, this is good in my book.

  • xjm committed 9dfbd47 on 8.4.x 
    Issue #2886198 by acbramley: Refactor \UserLoginHttpTest::testLogin() to...

  • xjm committed 53f47ac on 8.3.x 
    Issue #2886198 by acbramley: Refactor \UserLoginHttpTest::testLogin() to...
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 8.4.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Fixed

I looked over this with git diff -W to review the refactoring. Committed and pushed to 8.4.x. Since this issue only changes code internal to one test, it's also eligible for backport, so I've backported it to 8.3.x as well to keep the branches in sync.

Thanks @acbramley!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Wow, that was fast! Thanks everyone!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.