Problem/Motivation

#2852608: Review layout CSS and markup made one small mistake with the 33/34/33 layout.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2885878-layout-2.patch710 bytestim.plunkett

Comments

tim.plunkett created an issue. See original summary.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new 2885878-layout-2.patch710 bytes
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

I guess 1% is important.

manuel garcia’s picture

manuel garcia commented

Oops, good catch. Patch fixes this, +1 to rtbc

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Looks good to me, and got me singing `1% of 1` by SM + the jicks, so bonus points for that

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 8.4.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Fixed

Ha, a small but important fix, thanks.

  • Gábor Hojtsy committed c8575e2 on 8.3.x 
    Issue #2885878 by tim.plunkett: Threecol layout 33/34/33 is only 33/33/...

  • Gábor Hojtsy committed 5b8e948 on 8.4.x 
    Issue #2885878 by tim.plunkett: Threecol layout 33/34/33 is only 33/33/...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.