Why couldn't the popup have something like cookie-compliance class instead of sliding-popup?

CommentFileSizeAuthor
#4 eu_cookie_compliance-css-namespace-2885403-4.patch6.18 KBsvenryen

Comments

hkirsman created an issue. See original summary.

hkirsman’s picture

hkirsman commented

Also this it too specific and id's are never good idea:
#sliding-popup .popup-content #popup-text p

It's hard to over-ride this without using !important + if you have so deep selector then it costs a lot for browser to calculate. Rather it should be something like this:
.eu-cookie-compliance p {
}

There are other things also. I suggest refactoring css.

svenryen’s picture

svenryen commented

Indeed, those are valid points. If you have a suggestion for how we can improve this whil NOT BREAKING backwards compatibility, you're welcome to submit a patch.

svenryen’s picture

svenryen commented
Status: Active » Needs review
StatusFileSize
new eu_cookie_compliance-css-namespace-2885403-4.patch6.18 KB

Here's a patch that provides cleaner css and more sensible class names.

I can't remove any existing classes, as many users may have overrides for them in their css, but at least this should allow overriding eu-cookie-compliance css classes without having to use 4-5 selectors for each override.

  • svenryen committed f6f7b15 on 8.x-1.x 
    Issue #2885403 by svenryen: CSS namespace
svenryen’s picture

svenryen commented

I pushed this to -dev. If anybody has objections, please submit a different patch ;)

svenryen’s picture

svenryen commented
Status: Needs review » Fixed
hkirsman’s picture

hkirsman commented

Looks much better, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.