Closed (fixed)
Project:
Amazon Wysiwyg
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
9 Jun 2017 at 17:16 UTC
Updated:
20 Jul 2017 at 10:45 UTC
Jump to comment: Most recent
When an error happens while retrieving Amazon items, the errors are printed on the screen.
Example: B01DY7NWVY is not a valid value for ItemId. Please change this value and retry your request.
Task: Log errors and only show errors on the screen when the Wysiwyg plugin is being used.
Comments
Comment #2
marcelovaniAdding a fix on branch
http://cgit.drupalcode.org/amazon_wysiwyg/log/?h=2885022_error_messages
Commit here
http://cgit.drupalcode.org/amazon_wysiwyg/commit/?h=2885022_error_messag...
Needs testing, merging to 7.x-1.x and re-tagging
Comment #3
theapi commentedThe patch works, though the function changes cause an api change. Of course the functions prefixed with underscore imply private and should not be used outside of the module but some of those private function a useful.
May I suggest a 7.2 release and change the useful functions to not be private.
Comment #4
marcelovaniCool, done that and committed on a new branch 2.x
http://cgit.drupalcode.org/amazon_wysiwyg/diff/?h=7.x-2.x&id1=7c47517a5f...
Comment #5
marcelovani