When the "Use auto-detection of keywords from search engine referer" option is selected, and the HTTP_REFERER is accessed, I get the attached notice. (Check for whether this index is empty is not present in the code).

CommentFileSizeAuthor
#7 notice_on_accessing-2884936-6.patch691 bytesakhilavnair
#4 Screenshot from 2018-05-23 18:41:24.png179.8 KBchippyjacob
#2 search404-http-referer-unindexed-2884936-0-D8.patch1.03 KBanish_mathew
referernotice.png19.16 KBanish_mathew

Comments

anish_mathew created an issue. See original summary.

anish_mathew’s picture

anish_mathew commented
Status: Active » Needs review
StatusFileSize
new search404-http-referer-unindexed-2884936-0-D8.patch1.03 KB

attaching patch

websiteworkspace’s picture

websiteworkspace commented

I am seeing this error as well:


Undefined index: HTTP_REFERER in Drupal\search404\Controller\Search404Controller->search404SearchEngineQuery() 

line 263 of Search404Controller.php

As reported above, the following option is enabled:


Use auto-detection of keywords from search engine referer
This feature will conduct a search based on the query string got from a search engine if the URL of the search result points to a 404 page in the current website. Currently supported search engines: Google, Yahoo, Altavista, Lycos, Bing and AOL.
chippyjacob’s picture

chippyjacob commented
Issue summary: View changes
StatusFileSize
new Screenshot from 2018-05-23 18:41:24.png179.8 KB

Yes this worked for me!! No issue even after I enabled this option.

chippyjacob’s picture

chippyjacob commented
chippyjacob’s picture

chippyjacob commented
Status: Needs review » Reviewed & tested by the community

Reviewed and it works for me!

akhilavnair’s picture

akhilavnair
Primary language Malayalam
Location Kerala
commented
StatusFileSize
new notice_on_accessing-2884936-6.patch691 bytes

Hi All,

Re-rolling the patch to fix the merge issue.

zyxware’s picture

zyxware commented
zyxware’s picture

zyxware commented
Status: Reviewed & tested by the community » Fixed

Applied the patch. Marking the issue as fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.