#2856808: Break out the 'entity_test_update' entity type into its own module and add additional test db dumps moved the EntityTestUpdate entity type class into its own module. In comment #11 of that issue, @amateescu says
realized that I didn't delete the existing EntityTestUpdate class in the latest patches
and while the interdiff is correct, as far as I can tell, the patches do the exact opposite. The ones before this comment were removing the class, the ones after are not, including the one that was committed.
Thus, we have two EntityTestUpdate classes: the old one still in entity_test and the new one in entity_test_update. This is very confusing.
Remove the obsolete EntityTestUpdate class in entity_test.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | interdiff.txt | 911 bytes | amateescu |
| #5 | 2884894-5.patch | 3.56 KB | amateescu |
| #2 | 2884894.patch | 2.67 KB | amateescu |
Comments
Comment #2
amateescu commentedI was planning to remove this leftover in #2860654: Field storage CRUD operations must use the last installed entity type and field storage definitions, but that one turned out to be more than a test-only issue so it makes sense to do it here :)
Comment #3
tstoecklerAwesome, thank you!
Comment #5
amateescu commentedRight, that hook is still needed so we just have to move it to the right place. Hope it's ok to re-rtbc this one for such a simple change :)
Comment #6
tstoecklerAhh right. Makes sense, thanks!
Comment #7
gábor hojtsyHm, but the two classes look strangely different. Eg. the one being removed has revisions but the one that is supposedly replacing it does not have it, etc. I would assume the feature changes (lots more code in the class that would remain) are test additions but the removed test elements, eg. revisions would also be intentional?
Comment #8
amateescu commented@Gábor Hojtsy, yep, all the removals were done intentionally in #2856808: Break out the 'entity_test_update' entity type into its own module and add additional test db dumps in order to have a clean entity class that can be modified to be whatever we need it to be (revisionable, translatable) "on the fly" via alter hooks and the State system.
Comment #11
gábor hojtsySuperb, thanks.