Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
A couple of issues (#2721313: Upgrade path between revisionable / non-revisionable entities and #2854732: Use initial values for content translation metadata fields and fix existing data) have a need for update path database dumps that contain a test entity type with actual data.
Proposed resolution
- Move entity_type_update into its own module so we don't have to worry about all the entity types provided by the entity_test module
-
Provide two new test database dumps which contain data for the entity_test_update entity type:
drupal-8.0.0-rc1-filled.standard.entity_test_update.php.gz
contains 102 non-translated and non-revisioned entitiesdrupal-8.0.0-rc1-filled.standard.entity_test_update_mul.php.gz
contains 102 translated and non-revisioned entities
Both database dumps were created on Drupal 8.0.0-rc1 because we should try to support sites that want to upgrade from 8.0.0 directly to 8.4.0 without going through each minor version in between.
Remaining tasks
Review the patch.
User interface changes
Nope.
API changes
Nope.
Data model changes
Nope.
Comment | File | Size | Author |
---|---|---|---|
#18 | 2856808-17.patch | 340 KB | catch |
#18 | 2856808-interdiff.txt | 3.36 KB | catch |
#16 | 2856808-16.patch | 340 KB | catch |
#16 | 2856808-interdiff.txt | 3.36 KB | catch |
#11 | interdiff.txt | 3.47 KB | amateescu |
Comments
Comment #2
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedHere it is :)
Comment #5
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedRight, the problem is that this entity type needs to be used for generating dump from early D8 releases (i.e. 8.0.0-rc1), and
ContentEntityBase
was not providing base field definitions for entity keys at that time so we need to duplicate most of its code.This fixes the fails and now I have to try and see if the two db dumps are actually useful for #2721313: Upgrade path between revisionable / non-revisionable entities and #2854732: Use initial values for content translation metadata fields and fix existing data.
Comment #6
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedOops, forgot the interdiff.
Comment #8
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedFinally managed to validate that #2721313: Upgrade path between revisionable / non-revisionable entities works with this patch, after making the following small changes.
The dumps were updated as well but I didn't include them in the interdiff.
Now I'm going to also validate that tests can be written for #2854732: Use initial values for content translation metadata fields and fix existing data using the dumps added here.
Comment #10
timmillwoodLooks good. Going straight from Needs Word to RTBC because it did actually pass in #8.
Ha!
Comment #11
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedRerolled for the array syntax conversion and also realized that I didn't delete the existing
EntityTestUpdate
class in the latest patches and that we should mark some of its fields storages as required in anticipation for #2841291: Fix NOT NULL handling in the entity storage and 'primary key' changes when updating the storage definition of an identifier field.Comment #13
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedMost likely a bot fluke, let's try again.
Comment #15
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedAnd again :)
Comment #16
catchDidn't pass coding standards checks, uploading a patch that should.
Comment #18
catchWell.
Comment #19
amateescu CreditAttribution: amateescu for Pfizer, Inc. commentedThanks, @catch :)
The first change doesn't look right to me but if that's what the coding standards say..
Comment #21
catchCommitted/pushed to 8.4.x, thanks!
I think we should cherry-pick this to 8.3.x so that any changes don't need porting between branches, but waiting for a +1 from another committer.
Fixed this on commit:
Comment #22
alexpottI agree that this should be cherry-picked to 8..3.x - whilst there might be some disruption to contrib tests it is just tests and maintaining different tests across 8.3.x and 8.4.x is more painful than 8.2.x and 8.3.x/8.4.x since 8.2.x is about to be obsolete.
Comment #23
jibran+1 to #22.
Comment #24
catchCherry-picked to 8.3.x, thanks!