When adding fivestar field for any views field. 'assets/js/fivestar.js' file throws an error. Attaching screenshot.

There is a syntax issue . fixing which fixes the problem.

CommentFileSizeAuthor
#3 JS-issue-fix-2884270-12118524.patch694 bytesswastik1608
Fivestart - broken result.png8.55 KBswastik1608
FIvestar - console - error.png41.04 KBswastik1608

Comments

swastik1608 created an issue. See original summary.

swastik1608’s picture

swastik1608 commented

Patch for JS issue

swastik1608’s picture

swastik1608 commented
StatusFileSize
new JS-issue-fix-2884270-12118524.patch694 bytes

Js patch for fivestar widget

swastik1608’s picture

swastik1608 commented
Assigned: swastik1608 » Unassigned
Status: Needs work » Needs review
gg24’s picture

gg24 commented
Status: Needs review » Reviewed & tested by the community

Hi @swastik1608,

Patch #3 applies cleanly and works as intended for me. Issuing RTBC for it. If needed can mention steps followed for testing as well.

Thanks!

dbt102’s picture

dbt102 commented

Thanks for the patch @swastik1608, and for testing @gg24 !!!

Looks good to me.

  • dbt102 committed 57425cc on 8.x-1.x authored by swastik1608 
    Issue #2884270 by swastik1608, gg24, dbt102: Js throws an error for...
dbt102’s picture

dbt102 commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: -js bug