This is very similar to #2283719: Duplicate links for text and icons in Panels IPE which addressed the fact that selecting a pane to add in the Panels IPE had a two separate link on the icon and the text, rather than a single link that wrapped both the icon and the text for that pane.
However, this issue isn't about selecting the pane, but selecting the layout in the Panels IPE!
This creates problems for accessibility, where keyboard users (or users of accessible devices that emulate the keyboard) have to TAB twice for each layout (which will be double confusing for first time users, as they won't immediately know that both links are equivalent).
Like with #2283719, we should have a single link that wraps both the icon and the text!
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | interdiff.txt | 696 bytes | dsnopek |
| #3 | panels-ipe-layout-link-2883982-3.patch | 2.04 KB | dsnopek |
Comments
Comment #2
dsnopekHere's a patch that works in my testing
Comment #3
dsnopek@cboyden found a bug in this! It was a my stupid mistake. Here's a new patch to fix!
Comment #4
cboyden commentedWe've been using this patch, it's working as expected.
Comment #6
joelpittetThank you both for this fix, divs aren't allowed in a tags :)