While committing #2879757: Add phenaproxima and seanB as subsystem maintainers for Media, I noticed that the Migrate subsystem sections are not in alphabetical order—and by this I mean the sections in relation to other sections:

Markup
- ?

Migrate
- Adam Globus-Hoenich 'phenaproxima' https://www.drupal.org/u/phenaproxima
- Ben Dougherty 'benjy' https://www.drupal.org/u/benjy
- Lucas Hedding 'heddn' https://www.drupal.org/u/heddn
- Mike Ryan 'mikeryan' https://www.drupal.org/u/mikeryan
- Vicki Spagnolo 'quietone' https://www.drupal.org/u/quietone

Migrate (Drupal)
- Ben Dougherty 'benjy' https://www.drupal.org/u/benjy
- Lucas Hedding 'heddn' https://www.drupal.org/u/heddn
- Mike Ryan 'mikeryan' https://www.drupal.org/u/mikeryan
- Vicki Spagnolo 'quietone' https://www.drupal.org/u/quietone

Media
- Sean Blommaert 'seanB' https://www.drupal.org/u/seanb
- Adam Globus-Hoenich 'phenaproxima' https://www.drupal.org/u/phenaproxima

Menu
- Daniel Wehner 'dawehner' https://www.drupal.org/u/dawehner
- Peter Wolanin 'pwolanin' https://www.drupal.org/u/pwolanin

Menu Link Content
- Daniel Wehner 'dawehner' https://www.drupal.org/u/dawehner
- Peter Wolanin 'pwolanin' https://www.drupal.org/u/pwolanin

Menu UI
- ?
CommentFileSizeAuthor
#10 2883921-10.patch1.12 KBvinothkannan
#6 migrate_sections_in_alphabetical_order-2883921-6.patch1.56 KBdharizza

Comments

cilefen created an issue. See original summary.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

The following entries in MAINTAINERS.txt are not in alphabetical order:

BigPipe, Block, Classy, Comment, Config Entity API, Config Translation, Contact, DateTime, DateTime Range, JavaScript, Language, Migrate, Migrate (Drupal), Node Access, Page Cache, Plugin, Quick Edit, Shortcut, Taxonomy, Testing framework, Theme API, Views, API-first Initiative, Layout Initiative, PHPUnit Initiative (provisional)

For many of those, including ones I'm part of, I believe the custom order is purposeful

This might be as designed?

Reading comprehension is key.

cilefen’s picture

cilefen commented
Issue summary: View changes

"...and by this I mean the sections in relation to other sections".

Harsh424jan’s picture

Harsh424jan commented
Status: Active » Fixed

The issue has been fixed on the link in the issue

cilefen’s picture

cilefen commented
Status: Fixed » Active

No.

dharizza’s picture

dharizza commented
Status: Active » Needs review
StatusFileSize
new migrate_sections_in_alphabetical_order-2883921-6.patch1.56 KB

Hi! I just uploaded a patch for this.

dinesh18’s picture

dinesh18 commented
Status: Needs review » Reviewed & tested by the community

I have reviewed the patch manually and it looks good.
Changing the status to RTBC.

  • Gábor Hojtsy committed 983f022 on 8.4.x 
    Issue #2883921 by dharizza: Place migrate sections in alphabetical order...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Put migrate sections in alphabetical order in MAINTAINERS.txt » Place migrate sections in alphabetical order in MAINTAINERS.txt
Version: 8.4.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks for the quick fix. The list of modules looks like alphabetical other than these outliers, so committed :)

It did not merge cleanly to Drupal 8.3.x so leaving open for a backport.

vinothkannan’s picture

vinothkannan commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 2883921-10.patch1.12 KB

HI

Attaching patch for 8.3.x

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

  • Gábor Hojtsy committed 5ecb5e2 on 8.3.x 
    Issue #2883921 by vinothkannan, dharizza: Place migrate sections in...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Superb, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.