CommentFileSizeAuthor
#8 gratuities_styles-2883544-8.patch294.39 KBTylerMarshall
#7 gratuities_styles-2883544-7.patch294.39 KBTylerMarshall
#2 gratuities_styles-2883544-2.patch301.39 KBsmccabe
Image+Pasted+at+2017-6-2+14-29.png24.96 KBsmccabe

Comments

smccabe created an issue. See original summary.

smccabe’s picture

smccabe commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new gratuities_styles-2883544-2.patch301.39 KB
subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented 
  1. +++ b/sass/_sidebar.scss
@@ -108,6 +86,39 @@
+      color: #fff;

    Use variables for this please 

  2. +++ b/sass/_sidebar.scss
@@ -108,6 +86,39 @@
+      opacity: 0;

    Use Sass method for opacity 

  3. +++ b/sass/_sidebar.scss
@@ -108,6 +86,39 @@
+      opacity: 1;

    Use sass method for opacity

EDIT:
Removed the CSS change suggestions as those are all compiled code.

subhojit777’s picture

subhojit777
he/him
Primary language Bengali
commented
Status: Needs review » Needs work
smccabe’s picture

smccabe commented

@subhojit777 the CSS is compiled from SASS, so it is minified on purpose, you'll want to review the .sass files

TylerMarshall’s picture

TylerMarshall commented
Status: Needs work » Reviewed & tested by the community

Looks good to me, patch applies cleanly.

Only piece of feedback I'd have is to move the text like 1 or 2 px up but I'm a terrible front end person so maybe not.

TylerMarshall’s picture

TylerMarshall commented
StatusFileSize
new gratuities_styles-2883544-7.patch294.39 KB

If we want the +2 px on bottom here is the patch.

TylerMarshall’s picture

TylerMarshall commented
StatusFileSize
new gratuities_styles-2883544-8.patch294.39 KB

Sorry, broken patch above.

TylerMarshall’s picture

TylerMarshall commented
Status: Reviewed & tested by the community » Needs review

Updated to needs review so we can check if my patch is needed/wanted.

smccabe’s picture

smccabe commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.