Variable_set is a rather cumbersome function, since it makes a table modification and invalidates the cache of variables which must therefore be reloaded. It is therefore necessary to do so only when a modification is actually made, not in a systematic manner at each loading as this module does

CommentFileSizeAuthor
#4 performance_optimisation-2881362-4.patch860 bytesrenatog
#2 performance_optimisation-2881362-1.patch832 byteszied_bhar

Comments

zied_bhar created an issue. See original summary.

zied_bhar’s picture

zied_bhar commented
StatusFileSize
new performance_optimisation-2881362-1.patch832 bytes
renatog’s picture

renatog commented
Assigned: zied_bhar » renatog
Issue tags: +ciandt-contrib
renatog’s picture

renatog commented
Assigned: renatog » Unassigned
Status: Active » Reviewed & tested by the community
StatusFileSize
new performance_optimisation-2881362-4.patch860 bytes

Hi @zied_bhar

You're right. Make sense set in variable only if has modifications.

I re-generate a new patch because code is updated okay?! New patch it's in attachment.

Works fine for me.

+RTBC

Regards.

rhormens’s picture

rhormens commented

Thanks guys.
I will commit!

Please wait a new release.

  • rhormens committed 3564b46 on 7.x-2.x authored by RenatoG 
    Issue #2881362 by zied_bhar, RenatoG, rhormens: Performance optimisation
rhormens’s picture

rhormens commented
rhormens’s picture

rhormens commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.