Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
This is a backport of #2860663: UserTimeZoneTest fails on PHP 7.0.x-dev and 7.1.x-dev to Drupal 7, since it's now causing PHP 7 test failures in Drupal 7 also. See https://www.drupal.org/pift-ci-job/676235 as well as the discussion in #2877243: DATE_RFC7231 already defined in PHP 7.0.19 and 7.1.5.
Comment | File | Size | Author |
---|---|---|---|
#2 | 2880700-2.patch | 2.57 KB | David_Rothstein |
Comments
Comment #2
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedHere is the backport.
Comment #3
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedThose tests passed as expected (the other PHP 7.1 failures are preexisting and unrelated).
It's a pretty straightforward backport - anyone want to review/RTBC it?
Comment #4
cilefen CreditAttribution: cilefen commentedI updated PHP and showed that UserTimeZoneFunctionalTest fails without the patch. It's the exact same idea as the D8 patch and looks good.
Comment #5
joseph.olstadThanks DavidRothstein and cilefen!
I hope to be soon running php7 and/or maybe 7.1, appreciated
Comment #6
David_Rothstein CreditAttribution: David_Rothstein as a volunteer commentedCommitted to 7.x - thanks!