This is a backport of #2860663: UserTimeZoneTest fails on PHP 7.0.x-dev and 7.1.x-dev to Drupal 7, since it's now causing PHP 7 test failures in Drupal 7 also. See https://www.drupal.org/pift-ci-job/676235 as well as the discussion in #2877243: DATE_RFC7231 already defined in PHP 7.0.19 and 7.1.5.

CommentFileSizeAuthor
#2 2880700-2.patch2.57 KBDavid_Rothstein

Comments

David_Rothstein created an issue. See original summary.

David_Rothstein’s picture

David_Rothstein commented
Status: Active » Needs review
StatusFileSize
new 2880700-2.patch2.57 KB

Here is the backport.

David_Rothstein’s picture

David_Rothstein commented

Those tests passed as expected (the other PHP 7.1 failures are preexisting and unrelated).

It's a pretty straightforward backport - anyone want to review/RTBC it?

cilefen’s picture

cilefen commented
Status: Needs review » Reviewed & tested by the community

I updated PHP and showed that UserTimeZoneFunctionalTest fails without the patch. It's the exact same idea as the D8 patch and looks good.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Thanks DavidRothstein and cilefen!
I hope to be soon running php7 and/or maybe 7.1, appreciated

David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks!

  • David_Rothstein committed 370fd89 on 7.x 
    Issue #2880700 by David_Rothstein, cilefen, mpdonadio, xjm, Mile23:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.