Make Link URI required if there is Link Text input

Updated Patch (only the front end Part was missing. Backend validation was comitted somehow else).

Re-add the new test from patch #3.
Sorry. This didn't work. #15 works, but does not have an additional test.

Slightly changed patch taken from #3203656: Make uri required on the front-end when title filled-in. The patch from #15 does only apply if the link title is set to required, but it should also apply if the link title is set to optional. Link uri will still be required in that case.

The last patch works fine , when we type anything on the link text field the red asterisk will show above the URL field

Before patch

After patch

RTBC

anyone interested in this behavior without patching core can use Link Field Tweak module until this might get into core.

Verified and tested patch#18. Patch applied successfully.

Testing Steps:
1. Goto "Create content" page with Link field
2. Check Link field is optional
3. Enter Link text field
4. Check URI is not required
5. Now apply patch#18
6. Again enter Link text field
7. Verify URI is required

Test Result: On entering value in Link text field > URI field is required

Before Patch:

After Patch:

Moving to RBTC

Thanks for filing this bug report and for fixing the issue. Bug fixing is very valuable. In order to commit a bug fix, we need an automated test to prove that we've fixed the bug and ensure that we don't break it again in the future. For more information about writing tests in Drupal, see the following links:

1. https://www.drupal.org/docs/testing/phpunit-in-drupal/phpunit-javascript...
2. https://api.drupal.org/api/drupal/core%21core.api.php/group/testing/9.1.x

+++ b/core/modules/link/src/Plugin/Field/FieldWidget/LinkWidget.php
@@ -229,6 +229,22 @@ public function formElement(FieldItemListInterface $items, $delta, array $elemen
+    // Make uri required on the front-end when title filled-in.
+    if ((!$this->isDefaultValueWidget($form_state)) && !($this->getFieldSetting('title') === DRUPAL_DISABLED) && !$element['uri']['#required']) {
+      $field_name = $this->fieldDefinition->getName();
+
+      $parents = $element['#field_parents'];
+      $parents[] = $field_name;
+      $selector = $root = array_shift($parents);
+      if ($parents) {
+        $selector = $root . '[' . implode('][', $parents) . ']';
+      }
+
+      $element['uri']['#states']['required'] = [
+        ':input[name="' . $selector . '[' . $delta . '][title]"]' => ['filled' => TRUE],
+      ];
+    }

I think several minor tweaks can be made to this code.

    // Make uri required on the front-end when title filled-in.
    if (!$this->isDefaultValueWidget($form_state) && $this->getFieldSetting('title') !== DRUPAL_DISABLED && !$element['uri']['#required']) {
      $parents = $element['#field_parents'];
      $parents[] = $this->fieldDefinition->getName();
      $selector = array_shift($parents);
      if ($parents) {
        $selector .= '[' . implode('][', $parents) . ']';
      }
      $element['uri']['#states']['required'] = [
        ':input[name="' . $selector . '[' . $delta . '][title]"]' => ['filled' => TRUE],
      ];
    }

The if has lass brackets and work out if they mean anything. And less local variables.

Automation testing needs to be required to implement this patch.

Verified and tested patch #25 for drupal 9.3.x-dev.Patch applied successfully thanks@Meenakshi_j. Adding screenshot for reference.

Required Automation Testing.

The LinkFiledTest has already a test written for the logic above, I think its good enough.

if ($title_setting === DRUPAL_OPTIONAL) {
          // Verify that the URL is required, if the link text is non-empty.
          $edit = [
            "{$field_name}[0][title]" => 'Example',
          ];
          $this->submitForm($edit, 'Save');
          $this->assertSession()->pageTextContains('The URL field is required when the Link text field is specified.');
        } 

and After validating, the form is submitted with url only.

$value = 'http://www.example.com/';
    $edit = [
      "{$field_name}[0][uri]" => $value,
      "{$field_name}[0][title]" => '',
    ];  

Applied patch #25 working fine and applied successfully
Patch looks good for me
For ref sharing screenshots....

@alexpott's comments in #23 have not yet been addressed.

Here comes the test. ;-)

Fixed CS and change theme to stark.

This patch fixes the frontend but is there any backend validation done here? The states API for required only shows/hides the asterisk, it doesn't actually do any validation when the form is submitted, as far as I'm aware.

+++ b/core/modules/link/src/Plugin/Field/FieldWidget/LinkWidget.php
@@ -229,6 +229,21 @@ public function formElement(FieldItemListInterface $items, $delta, array $elemen
+    if ((!$this->isDefaultValueWidget($form_state)) && !($this->getFieldSetting('title') === DRUPAL_DISABLED) && !$element['uri']['#required']) {

This line is still confusing and @alexpott's changes haven't been done.

The server side is tested via core/modules/link/tests/src/Functional/LinkFieldTest.php:315.

So it is not possible to save the link just with the link text (without the patch).

And I do not see what is missing.

But I believe a better test class/method name would be better.

Class: LinkWidgetConditionalFormFieldTest
method: testLinkRequiredIsSet

?

I removed the unnecessary blank line and unnecessary brackets.

Btw @tobiasb is right about the server side validation. It has already.

I'm attaching a new patch, interdiff and a gif to confirm the server side validation (before patch is applied) which it has tests already.
Please review it.

Thanks! The new test looks good to me and proves that the new #states configuration works as expected.

Random fail, back to RTBC.

Back to RTBC per #40 after #3255836: Test fails due to Composer 2.2 solved the unrelated test failure.

I removed some issue credit where screenshots were uploaded duplicating previous manual testing - this only needs to be done once (or not at all if there is sufficient automated test coverage).

Committed/pushed to 10.0.x and cherry-picked back through to 9.3.x, thanks!