With our use of Layout Discovery (which is more stable and supported than Layout Plugin), its misleading to be throwing warnings on our customer sites.

Here is a patch for core that limits the experimental module warning to only appear when enabling a module. This will alert site builders when they choose to enable a module, but not scold our customers for making the correct choice, even though its experimental.

This original issue was migrated to core. Let's bring in that patch and two other patches related to core warnings. Specifically:

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

japerry created an issue. See original summary.

japerry’s picture

Status: Active » Needs review
FileSize
2.11 KB

Patch!

balsama’s picture

Status: Needs review » Closed (won't fix)

Thanks for filing this. I love the idea behind it. Layout Discovery is more stable than Layout Plugin and we're effectively scolding our users out of the box. The alternative is to remove Lightning Layout and eliminate 1/3 of our current user stories - which isn't reasonable.

The problem I see with this is that Lightning is (currently) making an exception for - "vouching" for - Layout Discover, and only Layout Discovery. Not the other Experimental Modules in core. There might be a VERY good reason to warn users that they have Datetime Range enabled. And if core pulls the API rug out from underneath Datetime Range, I don't want users of Lightning blaming us.

For the record, if core makes some monumental shift with Layout Discovery, Lightning will make sure users are supported. But, as the reporter of this issue knows better than anyone, that isn't expected :)

I'm closing this as won't fix so that my opinion is clear. I welcome more debate though. One possible compromise - since this is filed against Lightning - is to make the exception _only_ for Layout Discovery and leave the warning about other experimental modules. But I'm generally not a fan of one-offs like that.

japerry’s picture

Status: Closed (won't fix) » Needs work

So some will know that I'm a bit outspoken about the nagging messages on experimental modules (see #2766491: Update status should indicate whether installed contributed projects receive security coverage for more ;)) -- you may notice that I only removed the notice on top of the modules page and status page, not upon installing the modules.

I'd be fine with a compromise that includes layout discovery right now, as that needs to be a minimum for PS to pass its launch readiness checklist. However, I firmly believe that it should be at install time, when a builder/architect is choosing modules, that they need to evaluate if the pre-release or experimental module should be used. Once that decision is made, the site shouldn't be contradicting that decision. If history decides its the wrong decision, fine... but having an in-actionable warning on the site isn't going to make it any better.

japerry’s picture

I've added #2880374: Experimental modules and themes should not have warnings after being installed, since this should be handled in the core issue queue. We can make this a duplicate unless there is a specific reason to keep this issue open until the patch is added to the composer install file.

balsama’s picture

Issue summary: View changes
Status: Needs review » Needs work
balsama’s picture

Blog post explaining here:
http://lightning.acquia.com/blog/experimental-module-warnings-and-lightning

Set to Needs work for PR that adds the three patches identified in IS.

balsama’s picture

Status: Needs work » Needs review
phenaproxima’s picture

Status: Needs review » Fixed
phenaproxima’s picture

Status: Fixed » Closed (fixed)