Experimental modules and themes should not have warnings after being installed

I am fully on board with this, and I +1 the reasoning @japerry laid out in the IS.

IMHO, once you install an experimental module, the damage is done. You've jumped off the cliff, so you need to be responsible for ensuring that your wings work beforehand. You have made the choice (or, in Lightning's case, the choice has been made for you), and Drupal should shut up about it. Continuously warning the administrators is pointless -- what do we expect them to do? If the answer to that is "not use experimental modules", I do not agree. Panels and its ecosystem are the prime example of a stable module that is depending on an experimental module which no longer has any business being experimental, but will not be stable until 8.4 for policy reasons, not technical ones.

I am going to advocate for us to bring the patch in #2 into Lightning while the requisite debate takes place in this issue. Incidentally, I also agree with what @japerry re: the warning not having received any UX review (at least, nothing documented) before going into core. It deserved a proper discussion, so let's have that now.

Filed the corresponding Drush issue.

+1 for this.

+1 on this.

Back in #2657178: Warn about experimental modules on their help pages there was an issue to add warnings in three places once an experimental module is installed.

• During install
• On the modules page
• in the site status

Wrong issue. For example, the site status warning seems to have been added as a result of #2560597-5: Mark Migrate* modules as Experimental...

Agreed with the goal though. This patch keeps the message on the site status page but changes it from a warning to an informational message, which makes a lot of sense.

--- a/core/modules/help/src/Controller/HelpController.php
+++ b/core/modules/help/src/Controller/HelpController.php
@@ -117,11 +117,6 @@ public function helpPage($name) {
       $module_name = $this->moduleHandler()->getName($name);
       $build['#title'] = $module_name;
 
-      $info = system_get_info('module', $name);
-      if ($info['package'] === 'Core (Experimental)') {
-        drupal_set_message($this->t('This module is experimental. <a href=":url">Experimental modules</a> are provided for testing purposes only. Use at your own risk.', [':url' => 'https://www.drupal.org/core/experimental']), 'warning');
-      }
-

This is actually what was added in #2657178: Warn about experimental modules on their help pages. Instead of removing it, what about changing it from a warning to an informational message as well? (For example, prepending it to the normal help text or something like that.) I think the discussion in #2657178: Warn about experimental modules on their help pages explains why having some kind of message here is a good idea.

@David_Rothstein :

This patch keeps the message on the site status page but changes it from a warning to an informational message, which makes a lot of sense.

Did you mean to supply a patch with your comment? It's unclear where else "this patch" may be found if not :)

I was referring to the patch in comment #6 above.

For me, this is a wontfix that takes us in the wrong direction. People are under-warned about the risks of experimental modules, not over-warned.

Pictures speak louder than words. This is what happens if you update from 8.2.x to 8.3.x with Content Moderation enabled. Your site is unrecoverably broken with no workaround and no upgrade path.

This is a hard problem. We should try and prevent unrecoverable things from happening, but people will do stupid things.
Consistent/persistent warnings are not necessarily the answer, that's mostly training people to ignore them.

Would it help if we designed a super-ultra warning specifically for the scenario where people want to update their site and have experimentals installed? I guess that's only for updates through the UI then. Drush and Composer could do something as well?

(Aside: why the 1st tier vs other companies distinction? it does not seem relevant to the issue at hand).

Re-rolled.

Re-roll of the patch from comment #21 for 8.9.x-dev.

Forgot to attach the patch.

Wrong patch.

Correct test failures.

Sadly the patch in #30 no longer applies.

Reroll for 9.1.x.

After adding patch #33, experimental module warning disappeared from /admin/reports/status as well as admin/modules page
This can be moved to RTBC

Moving to RTBC

So in 2017, I agreed with @xjm in #2880374-13: Experimental modules and themes should not have warnings after being installed that this issue would have been won't fix.

However, we've significantly changed how experimental modules are added to core, so that they don't make it into a tagged release without a supported upgrade path. So it might be OK now. Tagging for release manager review so we get a chance to discuss it.

+++ /dev/null
@@ -1,65 +0,0 @@
-
-  /**
-   * Verifies that a warning message is displayed for experimental modules.
-   */
-  public function testExperimentalHelp() {
-    $this->drupalLogin($this->adminUser);
-    $this->drupalGet('admin/help/experimental_module_test');
-    $this->assertText('This module is experimental.');
-

This is useful information for site administrators, even if we don't show it as a warning. Moving back to needs review.

Addressing #38, it seems it would be best to provide a normal status message instead of a warning in the help system, then.

With the addition of claro, it is also important to not punish those users that chose to install it. I'm changing also the message type for themes to REQUIREMENT_INFO.

#39 looks good
Might need code review from FE/verbiage puprose

We were testing this against Drupal 9.3, 9.2, and 9.1 and found that the patch failed to apply.

Re-rolled the patch in #39 against 9.3.x-dev version.

Thanks!

Moving back to needs work for the test cases

Wrote a test case

Didn't mean to remove the tag, but I've pinged the other release managers and will remove in a few days if no objections.

Following up on this one.

It's been more than a few days, so I'm going to go ahead and remove the tag. We have warnings for deprecated modules, so if an experimental module ends up on its way out of core, people will be notified that way. The info level item is still a reminder you're running something that's not fully stable yet.

Let's bring it up in the RM channel so that folks have a chance to discuss and agree.

Could use screenshots of the info-level message in the status report. The test coverage asserts that the warning doesn't appear, but should that change to a positive assertion that an info appears?

Via @quietone:

+++ b/core/modules/system/system.install
@@ -98,7 +98,7 @@ function system_requirements($phase) {
       $requirements['experimental_modules'] = [
         'title' => t('Experimental modules enabled'),
         'value' => t('Experimental modules found: %module_list. <a href=":url">Experimental modules</a> are provided for testing purposes only. Use at your own risk.', ['%module_list' => implode(', ', $experimental_modules), ':url' => 'https://www.drupal.org/core/experimental']),
-        'severity' => REQUIREMENT_WARNING,
+        'severity' => REQUIREMENT_INFO,
       ];
     }
     // Warn if any deprecated modules are installed.
@@ -147,7 +147,7 @@ function system_requirements($phase) {

@@ -147,7 +147,7 @@ function system_requirements($phase) {
       $requirements['experimental_themes'] = [
         'title' => t('Experimental themes enabled'),
         'value' => t('Experimental themes found: %theme_list. Experimental themes are provided for testing purposes only. Use at your own risk.', ['%theme_list' => implode(', ', $experimental_themes)]),
-        'severity' => REQUIREMENT_WARNING,
+        'severity' => REQUIREMENT_INFO,
       ];

This patch is going too far. The scope should be limited to runtime warnings being turned to info mesages. We should still be warning about them during installation/update.

I am also not sure the warning should be removed from the help pages.

Sorry, crosspost.