coding standard to use short array syntax.

CommentFileSizeAuthor
#11 2877966-11.patch61.5 KBalexanderj
#8 fix_coding_standards-2877966-8.patch99.97 KBbhupesh_upadhyay
#5 coding-standard-fix-2877966-5.patch110.03 KBurvashi_vora
short-array-syntax.patch32.42 KBsathish.redcrackle

Issue fork poll-2877966

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sathish.redcrackle created an issue. See original summary.

Status: Needs review » Needs work

The last submitted patch, short-array-syntax.patch, failed testing. View results

megachriz’s picture

megachriz
Primary language Dutch
commented
Title: Coding standard changes » Coding standards: use short array syntax
Related issues: +#3089551: Code sniffer code style fixes

See also #3089551: Code sniffer code style fixes for more coding standard fixes.

urvashi_vora’s picture

urvashi_vora commented
Assigned: Unassigned » urvashi_vora

Hi,
I am looking after this

urvashi_vora’s picture

urvashi_vora commented
Assigned: urvashi_vora » Unassigned
Status: Needs work » Needs review
StatusFileSize
new coding-standard-fix-2877966-5.patch110.03 KB

Hi,

Please review this patch.

Thanks

Status: Needs review » Needs work

The last submitted patch, 5: coding-standard-fix-2877966-5.patch, failed testing. View results

bhupesh_upadhyay’s picture

bhupesh_upadhyay commented
Assigned: Unassigned » bhupesh_upadhyay

I'm working on this issue.

bhupesh_upadhyay’s picture

bhupesh_upadhyay commented
Assigned: bhupesh_upadhyay » Unassigned
Status: Needs work » Needs review
StatusFileSize
new fix_coding_standards-2877966-8.patch99.97 KB

I have fixed some coding standards, kindly review it.

Status: Needs review » Needs work

The last submitted patch, 8: fix_coding_standards-2877966-8.patch, failed testing. View results

alexanderj’s picture

alexanderj commented
Assigned: Unassigned » alexanderj

Hi, i will work on this.

alexanderj’s picture

alexanderj commented
Assigned: alexanderj » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2877966-11.patch61.5 KB

I made a reroll, as I read in the description, the goal is to apply the use of short array syntax, but I noticed that corrections are made to the default encoding that are already delegated in another issue, which is already linked to this task, so I kept "only" the modifications to use the short array syntax.
If there are some points to change, please comment so I can make the change or if the changes I made are not the correct way, please comment too.
Please review.

pflora’s picture

pflora commented
Status: Needs review » Reviewed & tested by the community

I agree with #11, in the sense that we need to make the scope of this issue pretty clear and adhere to it so that the maintainers can more easily review the changes if this is to be committed.

I've tested the most recent patch and it applies to a fresh drupal 9.4.7 installation. All tests are passing, and i've found no changes in the module behaviour.

Since all CS short array issues were corrected, i'm moving this to RTBC.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Parent issue: » #3417969: Adopt GitLab CI template

I'm planning to incorporate this ticket into #3417969: Adopt GitLab CI template so we can fix all those things in one single merge request.

Updating issue credits, not giving credits for simply applying PHPCBF.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Assigned: Unassigned » bramdriesen
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented

I can also confirm there are no more occurrences of "Drupal.Arrays.DisallowLongArraySyntax.Found" in the latest CI run: https://git.drupalcode.org/project/poll/-/jobs/714963

So the RTBC is justified.

bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed
bramdriesen’s picture

bramdriesen
he/him
Primary language Dutch
Location Belgium 🇧🇪🇪🇺
commented
Assigned: bramdriesen » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.