Closed (fixed)
Project:
Poll
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
30 Jan 2024 at 08:59 UTC
Updated:
29 Feb 2024 at 22:24 UTC
Jump to comment: Most recent
Problem/Motivation
It would be beneficial if we would adopt the Drupal Association GitLab CI template.
Proposed resolution
- Adopt template
- Fix any issues that block the pipeline from becoming green
Incorporated issues
Issues incorporated into this merge request (with correct commit attribution):
- #2877966: Coding standards: use short array syntax
- #3089551: Code sniffer code style fixes
- #2848118: Add a composer.json file
- #2952924: Dependency Injection issues
Remaining tasks
- Add config.yml
- eslint
- phpstan
- composer-lint
- phpcs
- stylelint
- phpunit
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Issue fork poll-3417969
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
bramdriesenComment #4
bramdriesenComment #5
bramdriesenComment #6
bramdriesenComment #7
bramdriesenComment #8
bramdriesenComment #9
bramdriesenProbably best to squash on commit
Comment #10
bramdriesenComment #11
bramdriesenComment #12
berdirleft some comments.
Personally I would definitely recommend to not do that much in a single MR, it's impossible to review. I only scrolled through a bit.
My preferred approach is to just enable tests with required test fixes and everything else in follow-ups, it's just warnings. But it's a bit late for that now, your call.
Comment #13
bramdriesenAfter some thought decided to proceed with it and tag a 2.0.x branch.
Drafted a release note for when the first release is tagged on the 2.0.x branch: https://www.drupal.org/node/3421654
Comment #14
berdirNote that using the gitlab UI to merge does by default not use the commit message format that's common in drupal, while having authors mentioned there or not is being discussed, but having that and the issue number allows to generate release notes with https://drupal-mrn.dev/
Comment #15
bramdriesenI should indeed have squashed it and used the message from the issue here. Normally I always do this, but have forgotten about it this time 😟 Unfortunately I can't git amend and do a force push.
Nice tool by the way!