Closed (fixed)
Project:
Bootstrap
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
10 May 2017 at 09:25 UTC
Updated:
5 Jun 2017 at 16:10 UTC
Jump to comment: Most recent, Most recent file


Comments
Comment #2
hkirsman commentedComment #3
grimreaperI will provide a patch.
Comment #4
grimreaperHere is a patch that fix the issue.
Thanks for the review.
Comment #5
ybenitezf commentedIn the same line you get the same result if you have a multi-language site, when you translate 'search' to to target language the glyph icon don't show and the button get broken.
Comment #6
markhalliwellThis shouldn't have to check the setting to set this property.
If anything, I'd say that the template just needs to also check if there's an icon input--button.html.twig (line 34).
Comment #7
grimreaperHello,
@markcarver: ok, here is reworked patch.
Comment #8
hkirsman commentedThe last patch worked for me. Thank you!
@ybenitezf, does this work for you too?
Comment #9
ybenitezf commentedBe testing it in a moment ... Yes thanks a lot it work the right way in all languages.
Comment #11
markhalliwell