Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When you have "Iconize Buttons" disabled at /admin/appearance/settings/bootstrap then the buttons don't show any text - it has class sr-only. In my opinion it should show text if icons are disabled.
Comment | File | Size | Author |
---|---|---|---|
#7 | bootstrap-iconize_search-2877263-7.patch | 872 bytes | Grimreaper |
#5 | Screenshot from 2017-05-20 14.40.49.png | 10.2 KB | ybenitezf |
#5 | Screenshot from 2017-05-20 14.40.08.png | 14.97 KB | ybenitezf |
#4 | bootstrap-iconize_search-2877263-4.patch | 2.16 KB | Grimreaper |
Screen Shot 2017-05-10 at 12.22.10.png | 37.72 KB | hkirsman |
Comments
Comment #2
hkirsman CreditAttribution: hkirsman commentedComment #3
GrimreaperI will provide a patch.
Comment #4
GrimreaperHere is a patch that fix the issue.
Thanks for the review.
Comment #5
ybenitezf CreditAttribution: ybenitezf commentedIn the same line you get the same result if you have a multi-language site, when you translate 'search' to to target language the glyph icon don't show and the button get broken.
Comment #6
markhalliwellThis shouldn't have to check the setting to set this property.
If anything, I'd say that the template just needs to also check if there's an icon input--button.html.twig (line 34).
Comment #7
GrimreaperHello,
@markcarver: ok, here is reworked patch.
Comment #8
hkirsman CreditAttribution: hkirsman commentedThe last patch worked for me. Thank you!
@ybenitezf, does this work for you too?
Comment #9
ybenitezf CreditAttribution: ybenitezf commentedBe testing it in a moment ... Yes thanks a lot it work the right way in all languages.
Comment #11
markhalliwell