Remove stale deprecated code.

That's strange that code removed begore 9.x but as IS said

We should update these deprecation notices. We agreed that we wouldn't do this. We have the chance of breaking tests if we do this. And that's wrong.

So mark them for removal before 8.5.x or before 9.0.0? Guessing 9.0.0. :-)

Also, they need @trigger_error() as per https://www.drupal.org/core/deprecation

Updated deprecation notices accordingly.Should @trigger_error be added to every method or only before the class declaration.

Based on https://www.drupal.org/core/deprecation, we can figure out that EntityUnitTestBase should @trigger_error() right after the namespace declaration.

The methods of JavascriptTestBase should get @trigger_error() at the end of execution in the deprecated methods.

And Drupal\KernelTests\KernelTestBase::__get() already triggers errors and throws exceptions for its special cases, because it's trying to tell you not to access those properties. So don't add another one.

We might well see some failed tests based on these changes.

Updated patch with comments from #7

+++ b/core/modules/system/src/Tests/Entity/EntityUnitTestBase.php
@@ -2,6 +2,10 @@
+@trigger_error(__FILE__ . ' is deprecated in Drupal 8.1.0 and will be removed ¶
+before Drupal 9.0.0. Use \Drupal\KernelTests\Core\Entity\EntityKernelTestBase ¶
+instead.', E_USER_DEPRECATED);

+++ b/core/tests/Drupal/FunctionalJavascriptTests/JavascriptTestBase.php
@@ -71,11 +71,13 @@ protected function tearDown() {
+    @trigger_error('The ' . __METHOD__ . ' method is deprecated since version ¶
+    8.1.0 and will be removed in 9.0.0. Use \Behat\Mink\Element\NodeElement::isVisible() instead.', E_USER_DEPRECATED);

@@ -86,11 +88,13 @@ protected function assertElementVisible($css_selector, $message = '') {
+    @trigger_error('The ' . __METHOD__ . ' method is deprecated since version ¶
+    8.1.0 and will be removed in 9.0.0. Use \Behat\Mink\Element\NodeElement::isVisible() instead.', E_USER_DEPRECATED);

We don't need newline for PHP code. Do you mind moving it into one line?

Updated patch. Moved them to one line.

The problem from #10 was fixed in #11.

I checked for change records for these changes - they don't exist. Since they are so old I don't think adding them now is that useful however have deprecation notices that correctly state that these things will be removed in Drupal 9 is.

Committed and pushed 2defaa4e44 to 8.6.x and c5df1de53b to 8.5.x. Thanks!

Since this is tests only backported to 8.5.x

Gave review credit to @dawehner and @Mile23