Problem/Motivation

I need to be able to supply a specific modal title, and customize the yes and no buttons with different text.

Proposed resolution

I am adding additional settings where the strings can be set.

Remaining tasks

Review the code

User interface changes

Added new settings form fields for title, yes button and no button.

API changes

None

Data model changes

The title, yes button text, and no button text are stored in the config data.

CommentFileSizeAuthor
#4 2876738-4.patch7.53 KBstrozx
#2 2876738-2.patch7.53 KBnace_fr
diff.txt5.42 KBmark.bradshaw

Comments

mark.bradshaw created an issue. See original summary.

nace_fr’s picture

nace_fr commented
StatusFileSize
new 2876738-2.patch7.53 KB

I fixed the patch naming and patch apply failing.

nace_fr’s picture

nace_fr commented
Status: Active » Needs review
strozx’s picture

strozx commented
StatusFileSize
new 2876738-4.patch7.53 KB

Reviewed it and added dependency injection for getting the site's name.

bcizej’s picture

bcizej commented
Status: Needs review » Reviewed & tested by the community

Reviewed and tested.

  • boshtian committed 73a77f6 on 8.x-1.x authored by nace_fric 
    Issue #2876738 by nace_fric, strozx, benjamincizej: Allow title, yes,...
boshtian’s picture

boshtian commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.