"symfony/yaml": "~2.7"

The symfony/yaml ~2.7 requirement has never been updated and conflicts with the drupal/core symfony ~3.2 and ^3.2 requirements.

Changing to ~2.7 || ~3.2 is the hot fix that would keep a composer merge happy. But is our serialization component compatible with both symfony/yaml 2.7 and 3?

Perhaps we can deduce the actual minimum version requirement by looking at the git logs. (Or by just looking at all the code if you're a symfony expert.)

CommentFileSizeAuthor
#2 fix_symfony_yaml_2_7-2876707-2.patch449 bytesscott_euser

Comments

Eric_A created an issue. See original summary.

scott_euser’s picture

scott_euser commented
Status: Active » Needs review
Issue tags: +SpringSprintLondon2017
StatusFileSize
new fix_symfony_yaml_2_7-2876707-2.patch449 bytes

Thanks for the hotfix tip! I've tested this with ./vendor/bin/phpunit -c core --group Serialization and all tests pass. Uploading patch to get full suite of tests to run on it.

eric_a’s picture

eric_a commented
Issue summary: View changes

@scott_euser, would our serialization component also be compatible with symfony/yaml 2.8? Given that symfony 3 is supposed to be symfony 2.8 with BC layers removed?

eric_a’s picture

eric_a commented
Issue summary: View changes
scott_euser’s picture

scott_euser commented

I don't know enough to give a good answer, but I'm hoping that the existing Yaml tests have coverage and will return some clues. It's running at the moment

eric_a’s picture

eric_a commented
Related issues: +#2867960: Merge Component composer.json files to account for them during build

@scott_euser, thanks for chiming in.

You might be interested in #2867960: Merge Component composer.json files to account for them during build. There's some background on the fact that these constraints are not taken into account currently. Also, your patch uses just ~3.2, which is the one that we have some test coverage for in drupal 8.4. Drupal 8.3 has some coverage for symfony/yaml 2.8. It seems likely that the component works fine with both symfony/yaml 3.2 and symfony/yaml 2.8 :-) It's symfony 2.7 and 3.0, 3.1 that are the really interesting constraints here. For example, would >=2.7 <=4.0.0 be expressing the truth.

scott_euser’s picture

scott_euser commented

I suppose we'd need someone who really understands the difference between the different yaml versions + what the plans are up to 4.x

For reference, throwing in the link to the changelog from 2.8-3.2:
https://github.com/symfony/yaml/blob/master/CHANGELOG.md

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

quietone’s picture

quietone commented
Status: Needs review » Closed (outdated)

@scott_euser, thanks for the patch.

This no longer relevant, Drupal 8.9 is using a later version, "symfony/yaml": "~3.4.5",. closing as outdated.