Hi,

The Subscriber class was declared but is not using. Remove it.

Code: use Drupal\simplenews\Entity\Subscriber;
Line: 21

Thanks

CommentFileSizeAuthor
#2 simplenews-remove_uselessness_code-2876617-2-8x.patch417 bytesmgoncalves

Comments

mgoncalves created an issue. See original summary.

mgoncalves’s picture

mgoncalves commented
Assigned: mgoncalves » Unassigned
Status: Active » Needs review
StatusFileSize
new simplenews-remove_uselessness_code-2876617-2-8x.patch417 bytes
hgunicamp’s picture

hgunicamp commented
Status: Needs review » Reviewed & tested by the community

I revised each assignment of the $subscriber variable and, for me looks enough importing only the SubscriberInterface, once 'SubscriberInterface::INACTIVE' and 'SubscriberInterface::ACTIVE' are used in simplenews.module file.

jonathanshaw’s picture

jonathanshaw
Primary language English
Location Stroud, UK
commented
Title: Remove uselessness code. » Remove unused simplenews\Entity\Subscriber from simplenews.module
Category: Bug report » Task

  • Berdir committed e3930ac on 8.x-1.x authored by mgoncalves 
    Issue #2876617 by mgoncalves: Remove unused simplenews\Entity\Subscriber...
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.