Remove dead D7 code

I revised each assignment of the $subscriber variable and, for me looks enough importing only the SubscriberInterface, once 'SubscriberInterface::INACTIVE' and 'SubscriberInterface::ACTIVE' are used in simplenews.module file.

Sorry. Wrong Issue.

After applying the 'simplenews-node_load_multiple-2876615-2-8x.patch' patch and using the command

find . -type f \( -name '*.inc' -or -name '*.module' -or -name '*.php' \) -exec grep --color=auto -e '\bnode_load_multiple' {} \+

I did not find any extra reference to 'node_load_multiple' function.

That appears to be dead D7 code, it uses l() and $item->nid which are things are not going to work in D8 at all.

No point in updating that, needs to be investigated if that function is unused and possibly removed completely.

There doesn't appear to be any code that calls this function, so can just remove it.

I have attached the patch to remove the function simplenews_recent_newsletters() function. The reason being that someone could be using this function in his own custom module. Removing this function will break his code. Anyway, the patch is attached in case you decide to go ahead with removing this function.

Thanks @neeravbm

Removing this function will break his code.

Thanks for checking. However see #7 this function will not work so any code calling it is already broken.

Oops I accidentally changed the status in #11.

@neeravbm NB your patch is in the wrong format - as @TR pointed out on the other issue.

Please read how to make patches before posting any more!