CommentFileSizeAuthor
#10 injection_services_and-2876569-10.patch33.6 KBgg24
#9 injection_services_and-2876569-9.patch32.68 KBgg24
#5 injection_services_and-2876569-5.patch32.98 KBgg24
#4 injection_services_and-2876569-4.patch32.68 KBgg24

Comments

gg24 created an issue. See original summary.

gg24’s picture

gg24 commented
gg24’s picture

gg24 commented
Related issues: +#2866241: Remove depreciated EntityManager, +#2866239: Deprecate db_select
gg24’s picture

gg24 commented
Assigned: gg24 » Unassigned
Status: Active » Needs review
StatusFileSize
new injection_services_and-2876569-4.patch32.68 KB

Please review the patch.

gg24’s picture

gg24 commented
StatusFileSize
new injection_services_and-2876569-5.patch32.98 KB

Removed @file tag docblock from all the .php files.

sonvir249’s picture

sonvir249 commented
Status: Needs review » Reviewed & tested by the community

Hi @gg24,

I have tested your patch. It's working properly.
Following are the testing steps taken.

  1. Enable the FAQ module.
  2. Add FAQ content type.
  3. CRUD operation is working properly of FAQ content type
  4. Go to faq-page to check the list of added FAQ's
  5. In order tab user can change the order of added FAQ's
  6. Go to FAQ settings (admin/config/content/faq)
    1. Change settings in General tab
    2. Change settings in Questions tab
    3. Change settings in Categories tab.
sumitmadan’s picture

sumitmadan commented
Status: Reviewed & tested by the community » Needs work

@gg24: I have pushed #2866237 to dev. So this patch doesn't apply now. Can you please re-roll the patch?

gg24’s picture

gg24 commented
Assigned: Unassigned » gg24
gg24’s picture

gg24 commented
Assigned: gg24 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new injection_services_and-2876569-9.patch32.68 KB

Hi @sonvir,

Re-rolled the patch with the latest changes. Thanks @sumitmadan.
Please review.

Thanks!

gg24’s picture

gg24 commented
StatusFileSize
new injection_services_and-2876569-10.patch33.6 KB

Hi,

Removed drupal_render from *.inc files too. Attaching a new patch with all the new changes as well.
Please check.

Thanks!

sonvir249’s picture

sonvir249 commented
Status: Needs review » Reviewed & tested by the community

Hi @gg24,

I have tested the latest patch, everything is working fine.
This can be marked as fixed. @sumitmadan.

Thanks.

  • gg24 authored 2bdc0f0 on 8.x-1.x 
    Issue #2876569 by gg24: Injection Services and Removed all deprecated...
sumitmadan’s picture

sumitmadan commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.