I thought it would be great if you could apply a quantity condition to a promotion so if a person purchases over a certain quantity then they would receive a discount. This seemed somewhat straight forward to create but I am having a little difficulty making it work for just the one item in the cart. It will pass if any item in the cart meets the condition and not just the product selected in the Promotion Offer.
I have the condition running on commerce_order_item as the target_entity_type but can't seem to find a way to access the Promotion Offer information or promotion entity from within the promotion condition class. Is this possible? I could add a product selection field to the promotion condition form but that seems redundant since you are already having to select a product from the ProductPercentOff Offer.
Also, what if the condition is only valid for a certain offer and doesn't really work for the other promotion offers. Thoughts?
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | commerce_promotion-OrderItemQuantity-2875370-7.patch | 5.34 KB | s_leu |
| #6 | OrderQuantity.txt | 2.59 KB | francois o |
| #3 | commerce_promotion-OrderItemQuantity-2875370-3.patch | 3.02 KB | trigdog |
Comments
Comment #2
steveoliver commentedSee https://github.com/drupalcommerce/commerce/pull/745
Comment #3
trigdog commentedThanks @steveoliver. That seems to work except I am looking more for a way to check the quantity of a given order item and not the total number of items in the order. Attached is a patch that works, except it returns true for any item in the cart that matches the quantity condition.
I would like to restrict it to the product(s) selected when choosing "Percentage off each product in the order" and whatever products are listed in the product field.
Currently, it doesn't seem this is how the relationship between the promotion offer and conditions work. Let me know if I am missing something here or if you have a good idea on how to remedy approach this. It may be that I just have to create a product select field in my condition but, like I said before, it seems a bit redundant when I will just be selecting the same product as list in the promo offer product field.
Comment #4
bojanz commentedI have included an OrderItemQuantity condition in the new condition API committed in #2885363: Create a commerce_condition plugin type, replacing commerce_promotion_condition.
Thus #3 is unneeded, repurposing the issue for steveoliver's order-level condition.
Setting to needs work cause this will need a reroll for the new API (and a move to commerce_order/src/Plugin/Commerce/Condition)
The confusing parts of offers will be fixed in #2886641: Refactor offers.
Comment #5
trigdog commentedGreat. Thank @bojanz
Comment #6
francois o commentedI had a need for order level quantity condition so came up with the attached.
Seems to work in my scenario.
Comment #7
s_leu commentedHere's reroll including the test from steveoliver in the PR on github.