In legacy Drupal web tests it was possible to use the verbose() method to get a dump of random data. In a PHPUnit world the verbose() method still exists but it requires the --debug method to be passed in as a command line argument ($_SERVER['argv']['--debug'] must exist). The problem is that there's no way of passing this through to PHP using run-tests.sh, and passing the --verbose argument to run-tests.sh doesn't then pass --debug to the tests. So this is a regression.
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | drupal-n2875038-14.patch | 462 bytes | damienmckenna |
| #8 | 2875038-8.patch | 1019 bytes | alexpott |
| #6 | drupal-n2875038-6.patch | 453 bytes | damienmckenna |
| #4 | drupal-n2875038-4.patch | 708 bytes | damienmckenna |
Comments
Comment #2
damienmckennaComment #3
damienmckennaEven if the if() statement is commented out, nothing happens with the output.
Comment #4
damienmckennaFor consideration - replace the logic in verbose() entirely with just a call to htmlOutput().
Comment #5
damienmckennaThis won't work in all cases as htmlOutput is in Drupal\Tests\BrowserTestBase, so the class hierarchy is off.
Comment #6
damienmckennaOk, lets just override verbose() in BrowserTestBase() so that it uses htmlOutput().
Comment #8
alexpottI think we should remove \Drupal\KernelTests\AssertLegacyTrait::verbose() then. Or maybe something like the attached patch.
This means verbose will throw an unsupported message in KernelTestBase - which is fine because it is not going to work so atleast it is honest. And eventually we will remove ->verbose() . There is a reason PHPUnit doesn't support this.
Comment #10
damienmckennaSo it seems the old verbose() message was being used by a good many methods throughout the codebase, even though since 8.3.x it wasn't having any effect. That's going to take a bit of time to work through.
Comment #14
damienmckennaReroll of #6.
Comment #15
damienmckennaAt the very least we need a replacement for the API and a change record.
Comment #19
quietone commentedTriaging issues in simpletest.module as part of the Bug Smash Initiative to determine if they should be in the Simpletest Project or core.
This looks like it a Phpunit issue, changing component.
Comment #21
mondrakeActually this doesn't do anything at all atm. With #2795567: Use Symfony's VarDumper for easier test debugging with dump() done, we may just deprecate it and remove its usages. For the purpose of debugging, at that point
dump()will cover most of the needs, I guess.Comment #22
alexpottThis has been resolved by #2795567: Use Symfony's VarDumper for easier test debugging with dump() and #3193163: Deprecate AssertLegacyTrait::verbose and remove its usage
Comment #23
damienmckennaThat works, thank you!