Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.As of 29th April all tests were passing, but on 30th April the API test has one fail at 8.3 and 8.4, but at 8.2 all tests still pass cleanly. No scheduler code was changed so something in core 8.3 and 8.4 must have been changed.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 2874410-2.null-value-in-fieldbyid.patch | 1.52 KB | jonathan1055 |
| |||
Comments
Comment #2
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedThe implementaion of
assertFieldById()has been corrected in core 8.4 and 8.3 yestertday - see #2868019-29: AssertLegacyTrait field assertions not compatible with Simpletest assertions. The commit was on 30th April 00:18, right at the correct time for our daily tests to show up the problem.Simple correction to the test code, when we do not care about the value, we should have used
NULLnot''for the second parameter, but we were getting away with it, due to the previously incorrect searching inassertFieldById().Comment #4
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedWe had a similar fault in #2824366-5: Move tests from /src/tests to tests/src/functional and extend BrowserTestBase instead of WebTestBase which was fixed in the same way using NULL not ''. It seems that the assertion for checkboxes was not fixed in core back then.