As of 29th April all tests were passing, but on 30th April the API test has one fail at 8.3 and 8.4, but at 8.2 all tests still pass cleanly. No scheduler code was changed so something in core 8.3 and 8.4 must have been changed.

CommentFileSizeAuthor
#2 2874410-2.null-value-in-fieldbyid.patch1.52 KBjonathan1055

Comments

jonathan1055 created an issue. See original summary.

jonathan1055’s picture

jonathan1055 commented
Status: Active » Needs review
Related issues: +#2868019: AssertLegacyTrait field assertions not compatible with Simpletest assertions
StatusFileSize
new 2874410-2.null-value-in-fieldbyid.patch1.52 KB

The implementaion of assertFieldById() has been corrected in core 8.4 and 8.3 yestertday - see #2868019-29: AssertLegacyTrait field assertions not compatible with Simpletest assertions. The commit was on 30th April 00:18, right at the correct time for our daily tests to show up the problem.

Simple correction to the test code, when we do not care about the value, we should have used NULL not '' for the second parameter, but we were getting away with it, due to the previously incorrect searching in assertFieldById().

  • jonathan1055 committed 9761c5c on 8.x-1.x 
    Issue #2874410 by jonathan1055: API test fails to find field at 8.3 and...
jonathan1055’s picture

jonathan1055 commented
Title: API test fails to find field at 8.3 and 8.4 » Tests with assertFieldById fail to find field at 8.3 and 8.4, ok at 8.2
Status: Needs review » Fixed

We had a similar fault in #2824366-5: Move tests from /src/tests to tests/src/functional and extend BrowserTestBase instead of WebTestBase which was fixed in the same way using NULL not ''. It seems that the assertion for checkboxes was not fixed in core back then.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.