We noticed that when using an EntityView block on a panel, after updating the underlying content, the block on the panel continued to show the previous state of the content. It appears that incorrect cache metadata is being applied so the cache tags for the underlying entity are never applied to the build info.

CommentFileSizeAuthor
#5 entityview-cache-metadata-2874176-5.patch620 byteswells
#2 entityview-cache-metadata-2874176-2.patch643 byteskevin.dutra

Comments

kevin.dutra created an issue. See original summary.

kevin.dutra’s picture

kevin.dutra commented
Assigned: kevin.dutra » Unassigned
Status: Active » Needs review
StatusFileSize
new entityview-cache-metadata-2874176-2.patch643 bytes

This should do the trick.

wells’s picture

wells
he/him/his
Primary language English
Location Seattle, WA
commented
Status: Needs review » Reviewed & tested by the community

Patch applies and correctly applies entity cache metadata instead of context cache metadata to the build array. Marking RTBC.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

@wells I committed #3178677: EntityView block overwrites cache metadata from build array LMK if I should revert and use this instead?

wells’s picture

wells
he/him/his
Primary language English
Location Seattle, WA
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new entityview-cache-metadata-2874176-5.patch620 bytes

@joelpittet this issue and patch addresses a different (but also pretty major) cache metadata issue -- that the metadata added is from the context instead of the context value (i.e. the entity). Both patches are needed to get the cache metadata sorted and working correctly. I am attaching a re-roll here that will apply to dev now and sending back to Needs review for tests.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

Ah thanks for clarifying and updating the patch so I didn't have to merge :) I've committed this to the dev branch as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.