It would be nice to allow more frequency options rather than just "only once" and "on every log in". Specifically, I would like once a year as an option, though there could be the possibility to add many more. Suggested patch to follow.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | agreement-2873904-frequency-options-10.patch | 9.38 KB | mradcliffe |
| #8 | agreement-2873904-frequency-options-8.patch | 9.38 KB | mradcliffe |
| #8 | interdiff-2873904-6-8.txt | 78.67 KB | mradcliffe |
| #6 | agreement_frequency_2873904_6.patch | 4.26 KB | bdlangton |
| #5 | agreement_frequency_2873904_5.patch | 2.84 KB | bdlangton |
Comments
Comment #2
bdlangton commentedHere is the patch. It only adds a "once per year" option, though it wouldn't be hard to expand to more options.
Comment #3
bdlangton commentedComment #5
bdlangton commentedUpdated patch with updated test.
Comment #6
bdlangton commentedIn addition to the frequency updates, it would be nice to be able to force a reset on the agreement. What that would do is force every user to re-accept the agreement. This adds a checkbox to the config form, so the admin when updating the agreement can choose to force users to re-accept.
I realize that this patch is extending the scope of the feature request. If you want to just look at the basic patch request, #5 is still the one to look at.
Comment #7
mradcliffeHopefully be able to take a look at it this week.
Comment #8
mradcliffeRe-rolled patch based on merging #1852834: Possible to have multiple agreements - role based.
This is probably ready to go. I moved the update number and adjusted it to affect agreement types instead. I think that you would need to reset schema_version to 7200, @bdlangton.
Comment #10
mradcliffeMessed that patch up, sorry.
Comment #11
bdlangton commented@mradcliffe Looks good to me. Thanks for the update.
Comment #13
mradcliffeCommitted to 7.x-2.x.