Add Change record for Revision Metadata Base Fields change to Annotation

Hi, I'm @ drupalcon Vienna and about to try to help with this issue.

Hi, there is only one deprecated private function. Since it is private nobody can use it outside of the class it self. The method is used only once on line 295. Is it worth documenting the necessary changes for this single usage?

@Janec thanks starting to this.

We don't want to create a separate issue for each file but for every change which may affect multiple files.. This @deprecated tag was added in #2248983: Define the revision metadata base fields in the entity annotation in order for the storage to create them only in the revision table which has 2 change record https://www.drupal.org/node/2831499 https://www.drupal.org/node/2870643

If there not already an issue for this we want to make sure that all @deprecated tags from that issue have @see tag pointing https://www.drupal.org/node/2831499

So we would also need to change the title of this issue to reflect the change record concept not an individual file.

There are 2 commits that mention #2248983: Define the revision metadata base fields in the entity annotation in order for the storage to create them only in the revision table : http://cgit.drupalcode.org/drupal/log/?qt=grep&q=2248983

Setting back to Active because there is not a patch yet.

Hi,

We're working on this issue together with @mecmartini during the SprintWeekend2018.

We've analyzed the original changes in: https://www.drupal.org/project/drupal/issues/2248983 and noticed that we need to add 2 references to the change of record: #2831499: Revision metadata fields are now defined in the entity annotation.

Patched attached below, also adjusted the title and description of the issue.

The #7 patch applies cleanly to 8.6.x.

Looks solid.

Crediting @time2buzzthetower for creating the issue, @tedbow for issue management and @mecmartini as according to #7 they worked on this too.

+++ b/core/modules/views/views.post_update.php
@@ -206,6 +206,9 @@ function views_post_update_grouped_filters() {
+ * @todo Remove in Drupal 9.0.x.

This is not really required. All post updates will be cleared out during the preparation for Drupal 9 - like hook_update_N()'s. Fixed on commit.

Committed and pushed 951b4334fb to 8.6.x and 2be4ef6160 to 8.5.x. Thanks!

As docs change backported to 8.5.x.