Add Change record to @deprecated for TypeLinkManagerInterface.php

CommentFileSizeAuthor
#8 drupal-change_records_for_deprecated-2873789-8.patch10.21 KBWim Leers
#8 interdiff.txt819 bytesWim Leers
#4 drupal-change_records_for_deprecated-2873789-4.patch11.01 KBponies
#2 drupal-change_records_for_deprecated-2873789-2.patch612 bytesponies
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ponies created an issue. See original summary.

ponies’s picture

ponies
Location Chico, CA
CreditAttribution: ponies as a volunteer and commented
Status: Active » Needs review
FileSize
drupal-change_records_for_deprecated-2873789-2.patch612 bytes

Adding patch for this issue.

ponies’s picture

ponies
Location Chico, CA
CreditAttribution: ponies as a volunteer and commented
Title: Add Change record to @deprecated for TypeLinkManagerInterface.php » Add Change record to @deprecated for TypeLinkManagerInterface
ponies’s picture

ponies
Location Chico, CA
CreditAttribution: ponies as a volunteer and commented
FileSize
drupal-change_records_for_deprecated-2873789-4.patch11.01 KB

Change log, https://www.drupal.org/node/2830467, references these issues:
https://www.drupal.org/node/2854830
https://www.drupal.org/node/2758897

Reviewed patches each and added @see urls.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Title: Add Change record to @deprecated for TypeLinkManagerInterface » Add change record to @deprecated for TypeLinkManagerInterface
Status: Needs review » Reviewed & tested by the community

Thanks!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/rest/src/Tests/RESTTestBase.php
@@ -14,6 +14,8 @@
+ * @see https://www.drupal.org/node/2830467

This one is incorrect; this one is due to #2824576: Delete old REST test coverage: (Read|Create|Update|Delete)Test, deprecate RESTTestBase, for which no CR exists yet.

Please remove this hunk.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

If no CR exists, then part of the scope should be to add one to the relevant issues. (Not necessarily creating small trivial change records; it may also be updating an existing change record to include more complete information.)

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Status: Needs work » Reviewed & tested by the community
FileSize
interdiff.txt819 bytes
drupal-change_records_for_deprecated-2873789-8.patch10.21 KB

#7: The scope of this issue is @deprecated for TypeLinkManagerInterface.

90% of this patch is ready to go. Therefore rerolling simply without the last hunk, then it's ready again.

(Note this is not self-RTBC'ing — this is removing one hunk and re-RTBC'ing.)

  • Gábor Hojtsy committed dcd645b on 8.3.x 
    Issue #2873789 by ponies, Wim Leers, xjm: Add change record to @...

  • Gábor Hojtsy committed 7d510cc on 8.4.x 
    Issue #2873789 by ponies, Wim Leers, xjm: Add change record to @...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Version: 8.4.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Fixed

Thanks all, committed this one :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kay_v’s picture

kay_v CreditAttribution: kay_v as a volunteer commented
Parent issue: #2873705: Add change records to all @deprecated code »

Removing parent issue per conversation with @xjm at Drupalcon Nashville Mentored Sprint prep. Her recommendation to do so was based on a few points that made sense to all of us in the discussion, namely:
- so many child issues makes this parent unwieldy
- search filters will allow people needing to refind closed children