Child issue of #2873705: Add change records to all @deprecated code.

Add Change record to @deprecated for Term.php on line 18

CommentFileSizeAuthor
#12 2873742-12.patch582 bytesheddn
#10 add_change_record_to-2873742-10.patch582 bytesAda Hernandez
#5 depreciated-see-2873742.patch588 bytesDrupalMattS
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhood created an issue. See original summary.

jhood’s picture

jhood
he/him
Primary language English
Location Ohio, United States
CreditAttribution: jhood commented

I was unable to find a change request for this and commented on the ticket where the change was made here https://www.drupal.org/node/2746671#comment-12060606

If anyone wants to pick this one up, feel free!

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Title: Add Change record to @deprecated for Term.php » Add Change record to @deprecated for Term
DrupalMattS’s picture

DrupalMattS CreditAttribution: DrupalMattS commented

Ill add the @see for this.

DrupalMattS’s picture

DrupalMattS CreditAttribution: DrupalMattS commented
FileSize
depreciated-see-2873742.patch588 bytes

Adding patch file for:

core/modules/taxonomy/src/Plugin/migrate/source/Term.php

tachiinii’s picture

tachiinii CreditAttribution: tachiinii as a volunteer commented
Status: Active » Reviewed & tested by the community

Check #5 @see link appears in Term class.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Needs work

The @see is linking back to this issue, which is very circular. We need to add the change record for the original issue before we can do anything here.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented

re #2: then let's create one. See https://www.drupal.org/contributor-tasks/draft-change-record for instructions.

Ada Hernandez’s picture

Ada Hernandez CreditAttribution: Ada Hernandez at MTech, LLC commented
Assigned: Unassigned » Ada Hernandez
Ada Hernandez’s picture

Ada Hernandez CreditAttribution: Ada Hernandez at MTech, LLC commented
Assigned: Ada Hernandez » Unassigned
Status: Needs work » Needs review
FileSize
add_change_record_to-2873742-10.patch582 bytes

For this @see the issue is https://www.drupal.org/node/2746671 because in this was added.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan as a volunteer and at Virtuoso Performance commented
Status: Needs review » Needs work
Related issues: +#2746671: CCK field data not available for D7 taxonomy term migrations

There's still no change record for #2746671: CCK field data not available for D7 taxonomy term migrations - one needs to be added, and the @see in this issue pointed to it.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
Status: Needs work » Needs review
FileSize
2873742-12.patch582 bytes

Added a CR. No interdiff.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Murphysboro, IL, USA
CreditAttribution: mikeryan as a volunteer and at Virtuoso Performance commented
Status: Needs review » Reviewed & tested by the community

The change record is published.

  • Gábor Hojtsy committed e1688b8 on 8.3.x 
    Issue #2873742 by heddn, DrupalMattS, Adita, jhood, mikeryan: Add Change...
Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy at Acquia commented
Version: 8.4.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Fixed

Superb, thanks all.

  • Gábor Hojtsy committed 7292b48 on 8.4.x 
    Issue #2873742 by heddn, DrupalMattS, Adita, jhood, mikeryan: Add Change...
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented
Issue summary: View changes
Parent issue: #2873705: Add change records to all @deprecated code »

Removing the issue relationship from fixed issues to keep the parent issue usable. Thanks!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm at Acquia commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.