I noticed a bunch of weird links at the top of my administration menu, sometimes they are filtered out but in one case they even showed up in the UI and messed it up pretty badly.
The current code is adding possibly quite a lot of menu links for non-existing menu link parents, we should check for that explicitly.
We could also try to make it more intelligent and match on the path, but better to not define them at all than in a messed up way.
This affects block_content_type in core, as well as file_entity and flag from what I've seen.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | admin_toolbar-check-parent-2873577-2.patch | 965 bytes | berdir |
Comments
Comment #2
berdirComment #3
gg24 commentedHi @Berdir,
Please mention the steps to reproduce this issue. I am not able to reproduce it as you mentioned this does not happen every time.
Please attach an image as well if possible. This would help me in understanding this issue in a better way.
Thanks!
Comment #4
berdirPossible that this only happens with file_entity and not block_content, all you need to do is enable both file_entity and admin_toolbar_tools and then /admin/structure/menu/manage/admin shows a bunch of weird top-level menu links.
Comment #5
adriancidHi @Berdir I' testing now the last dev version with the file_entity module enabled but I can't see the problem, can you re-test and add a image if the problem persists?
Comment #6
adriancidComment #7
adriancidI'm closing this as we can't reproduce the issue, if the problem persists please feel free to reopen and update the status.
Comment #8
adriancidThis issue solve the problem #2922046: Notice: Undefined index: entity.eform_type.collection in admin_toolbar_tools_menu_links_discovered_alter