Postponed (maintainer needs more info)
Project:
Conditional Fields
Version:
4.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Apr 2017 at 16:20 UTC
Updated:
4 Mar 2024 at 12:53 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
hyscaler commentedComment #3
hyscaler commentedComment #4
hyscaler commentedComment #5
rootworkI don't know enough about this to review, but the status should be needs review, not patch to be ported (that's used for porting a patch from one major version to another, like say from Drupal 8 to Drupal 7).
Comment #7
rootworkAdding the missing test group.
Comment #8
hyscaler commentedComment #10
eric.chenchao commentedThere is a related ticket #2873350: Warning: Invalid argument supplied for foreach() in Drupal\conditional_fields\Plugin\conditional_fields\handler\Select->statesHandler to address bugs when using other options.
Comment #11
eric.chenchao commentedComment #12
rootworkComment #13
bluestatedigital commentedRe-rolled the patch in #7 and resolved conflicts in OptionsButton.php and conditional_fields.api.inc.
Comment #14
bluestatedigital commentedComment #15
colanPatch no longer applies to HEAD so it needs a reroll (assuming it's still an issue). Also, there are coding standards problems:
There must be a space after "if" here and in other stanzas.
Anything inside of an "if" must be surrounded by squiggly braces, here and in other stanzas.
I'm seeing this stanza duplicated in several places. It should be moved to its own method to prevent such code duplication.
`
Comment #16
colanDowngrading priority as other features work. "Critical" means that the module is completely unusable.
Comment #17
dqdIs this issue still relevant for 4.x dev (Drupal 10)? Drupal 8/9 EOL. So: Would like to collect some thoughts/reports here to know how to go on.